From: Andrea Greco <andrea.greco.gapmilano@gmail.com>
To: "Tobin C. Harding" <tobin@apporbit.com>
Cc: m.grzeschik@pengutronix.de, Andrea Greco <a.greco@4sigma.it>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 2/3] arcnet: com20020: Fixup missing SLOWARB bit
Date: Tue, 8 May 2018 11:52:25 +0200 [thread overview]
Message-ID: <f17492c1-8565-2a69-22a8-c3abde0c7283@gmail.com> (raw)
In-Reply-To: <20180507025556.GG4197@eros>
On 05/07/2018 04:55 AM, Tobin C. Harding wrote:
> On Sat, May 05, 2018 at 11:37:54PM +0200, Andrea Greco wrote:
>> From: Andrea Greco <a.greco@4sigma.it>
>>
>> If com20020 clock is major of 40Mhz SLOWARB bit is requested.
>>
>> Signed-off-by: Andrea Greco <a.greco@4sigma.it>
>> ---
>> drivers/net/arcnet/com20020.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/net/arcnet/com20020.c b/drivers/net/arcnet/com20020.c
>> index f09ea77dd6a8..abd32ed8ec9b 100644
>> --- a/drivers/net/arcnet/com20020.c
>> +++ b/drivers/net/arcnet/com20020.c
>> @@ -102,6 +102,10 @@ int com20020_check(struct net_device *dev)
>> lp->setup = lp->clockm ? 0 : (lp->clockp << 1);
>> lp->setup2 = (lp->clockm << 4) | 8;
>>
>> + // If clock is major of 40Mhz, SLOWARB bit must be set
>
> /* C89 style comments please :) */
>
Done
>
> Hope this helps,
> Tobin.
>
prev parent reply other threads:[~2018-05-08 9:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-05 21:37 [RFC PATCH 2/3] arcnet: com20020: Fixup missing SLOWARB bit Andrea Greco
2018-05-07 2:55 ` Tobin C. Harding
2018-05-08 9:52 ` Andrea Greco [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f17492c1-8565-2a69-22a8-c3abde0c7283@gmail.com \
--to=andrea.greco.gapmilano@gmail.com \
--cc=a.greco@4sigma.it \
--cc=linux-kernel@vger.kernel.org \
--cc=m.grzeschik@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=tobin@apporbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).