From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrea Greco Subject: Re: [RFC PATCH 2/3] arcnet: com20020: Fixup missing SLOWARB bit Date: Tue, 8 May 2018 11:52:25 +0200 Message-ID: References: <20180505213754.8400-1-andrea.greco.gapmilano@gmail.com> <20180507025556.GG4197@eros> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: m.grzeschik@pengutronix.de, Andrea Greco , netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: "Tobin C. Harding" Return-path: In-Reply-To: <20180507025556.GG4197@eros> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 05/07/2018 04:55 AM, Tobin C. Harding wrote: > On Sat, May 05, 2018 at 11:37:54PM +0200, Andrea Greco wrote: >> From: Andrea Greco >> >> If com20020 clock is major of 40Mhz SLOWARB bit is requested. >> >> Signed-off-by: Andrea Greco >> --- >> drivers/net/arcnet/com20020.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/net/arcnet/com20020.c b/drivers/net/arcnet/com20020.c >> index f09ea77dd6a8..abd32ed8ec9b 100644 >> --- a/drivers/net/arcnet/com20020.c >> +++ b/drivers/net/arcnet/com20020.c >> @@ -102,6 +102,10 @@ int com20020_check(struct net_device *dev) >> lp->setup = lp->clockm ? 0 : (lp->clockp << 1); >> lp->setup2 = (lp->clockm << 4) | 8; >> >> + // If clock is major of 40Mhz, SLOWARB bit must be set > > /* C89 style comments please :) */ > Done > > Hope this helps, > Tobin. >