netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mason <slash.tmp@free.fr>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev <netdev@vger.kernel.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	David Miller <davem@davemloft.net>
Subject: Re: Waiting for the PHY to complete auto-negotiation
Date: Wed, 6 Dec 2017 20:00:42 +0100	[thread overview]
Message-ID: <f17b7d20-db9e-10eb-9cb1-f3fe1922e1e7@free.fr> (raw)
In-Reply-To: <20171206182633.GP27063@lunn.ch>

On 06/12/2017 19:26, Andrew Lunn wrote:

> On 06/12/2017 19:03, Mason wrote:
>
>> The problem with this is the following mind-boggling quirk of
>> the hardware: once RX DMA is enabled, there is no supported
>> way to disable it! Thus, I'm trying to find a clean way to set
>> the control flow parameter BEFORE enabling the MAC.
> 
> There is no solution. I can pull the cable out, and plug it into a
> different computer. The first could use flow control, the second not.
> 
> If you cannot disable RX DMA, you should probably disable unloading of
> the module. Also kexec.

It is not possible to /selectively/ disable RX DMA, but after a reset,
DMA is disabled. So the solution I propose is this:

When we detect link down, we put the chip in reset, so that we will
repeat initialization when the link comes back up.

Mans has been reluctant to adopt this approach, but this is what
I implemented in my forked version. I'm trying to push my changes
upstream, to minimize the differences.

Regards.

  reply	other threads:[~2017-12-06 19:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-06 16:39 Waiting for the PHY to complete auto-negotiation Mason
2017-12-06 16:59 ` Andrew Lunn
2017-12-06 18:03   ` Mason
2017-12-06 18:26     ` Andrew Lunn
2017-12-06 19:00       ` Mason [this message]
2017-12-06 19:07         ` Andrew Lunn
2017-12-06 19:25           ` Mason
2017-12-06 23:00             ` Florian Fainelli
2017-12-07 16:17               ` Mason
2017-12-09 18:49                 ` Florian Fainelli
2017-12-11 14:29                   ` Mason
2017-12-11 14:36                     ` Måns Rullgård
2017-12-11 14:47                       ` Mason
2017-12-11 16:32                         ` Måns Rullgård

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f17b7d20-db9e-10eb-9cb1-f3fe1922e1e7@free.fr \
    --to=slash.tmp@free.fr \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).