From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH net] ipv6: route: remove duplicated string from error message Date: Sat, 12 Jan 2019 13:07:14 -0800 Message-ID: References: <20190112204511.24710-1-jakub.kicinski@netronome.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, Roopa Prabhu To: Jakub Kicinski , davem@davemloft.net Return-path: Received: from smtprelay0008.hostedemail.com ([216.40.44.8]:50386 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726399AbfALVHR (ORCPT ); Sat, 12 Jan 2019 16:07:17 -0500 In-Reply-To: <20190112204511.24710-1-jakub.kicinski@netronome.com> Sender: netdev-owner@vger.kernel.org List-ID: On Sat, 2019-01-12 at 12:45 -0800, Jakub Kicinski wrote: > "IPv6: " prefix is already added by pr_fmt, no need to include > it again in the pr_warn() format. [] > diff --git a/net/ipv6/route.c b/net/ipv6/route.c [] > @@ -4256,7 +4256,7 @@ static void ip6_print_replace_route_err(struct list_head *rt6_nh_list) > struct rt6_nh *nh; > > list_for_each_entry(nh, rt6_nh_list, next) { > - pr_warn("IPV6: multipath route replace failed (check consistency of installed routes): %pI6c nexthop %pI6c ifi %d\n", > + pr_warn("multipath route replace failed (check consistency of installed routes): %pI6c nexthop %pI6c ifi %d\n", Thanks. Just asking, couldn't this emit a rather long list? Perhaps it should be ratelimited?