From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38277327BFC for ; Mon, 5 Jan 2026 08:23:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767601407; cv=none; b=EWBlGdytaSZTQfhu4wlGuRE6UpwMiMGoNlFYheppwFVI7k64jMuRZkkwa/QK+FyfKNMwvtwZX8oup9M9UIS5CyE2Ut9La9qYH0iyAumqVHeMgeQYdr+KdNydpEx+2/6D9Hd5+iqAPBfxSqzpb3GaYy9lpow6QwB8aTdAIzri0zM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767601407; c=relaxed/simple; bh=UZnbRwVvRPHcRgRCzpxYejrN2eYzh6K3qUvMvD+slXE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jyjzvR+24bkTL0Au30B5YlX9PeBfZXqJHIS64Er8Oy/yj/cVMRVf2IzC73Y/pBXDEZGZXhySPBVvLtG3utvPc1aAynxy3lkHj3HE3qaFqpTlDZb4633WdQ1uAafVg77ejqW3m7fl6micAMtbDVbqf0J9ih6uXfl4Z7e83sYyZSs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Va5i9zMe; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=eVeVMVFL; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Va5i9zMe"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="eVeVMVFL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767601404; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ixiBJgqmLTQwR4hP1VcNBLxgwUtr+SaYhPMs/HYsyIA=; b=Va5i9zMeMtbcRHGkO3omiS2lnbjK7NHJmRV04pl1aei+cXj/VonDubjoano/21Gzm6DJza NuqsI5jUFDMBOOIBPpcc5KxS9XpfJzugdzZmrvHTih1SwK+tDbSBdheB81od2wtPh6Ji6w llfG0vjl4L4Fd7EkQ7ac2tMIxB6DT/k= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-611-ONqSMZDoODaKDyLzlvFtNQ-1; Mon, 05 Jan 2026 03:23:23 -0500 X-MC-Unique: ONqSMZDoODaKDyLzlvFtNQ-1 X-Mimecast-MFC-AGG-ID: ONqSMZDoODaKDyLzlvFtNQ_1767601402 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-42fd46385c0so7407556f8f.0 for ; Mon, 05 Jan 2026 00:23:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767601402; x=1768206202; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ixiBJgqmLTQwR4hP1VcNBLxgwUtr+SaYhPMs/HYsyIA=; b=eVeVMVFLCc/3+rlgiQ+uX1PuOEip3OVCtfW/FVbq3GmJAX2XPqgSzQu3DI/Sx9Y491 1T7yEOJ+KvzNBcr/zxt4mKErGzWZZWXEi6p1dpNvdFl0loa445T/D3jyFCRSMehYMKyb Izb7utSZY8hYoW9yguzTL9X1LbFZQc/wOUjgQmwsCPNV94gLcNt8TAqV7i0cpZW5VIz5 pijgiyaL/lHySq/iE7pgV8Rp9v2LST+0Fw+KNsciR4l7nP0T4YUq7b2xK1P+6SZEL5aq N51P2VPsKgGYixHYeKCDmFq056ciBxj/kk1E3cSwu12el3grzvjWTjRJI1S+p3GQOPjH qb1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767601402; x=1768206202; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ixiBJgqmLTQwR4hP1VcNBLxgwUtr+SaYhPMs/HYsyIA=; b=VGNQwQytJZLDC/CgALVskdVsWXu2olJbgq+3KwwNmMDMGnmjg8DaJmRvYh/nv+xRkq zooumQxZMjfhOKTt6zVh0/IeTfaatxGLFSWTzJYxsspUaNAotBGbGfYHFPbw3aVwrNKv 5V9rFcORRK46fV4WK8DkHXAI5sbkQofO4mxWROxS/ZCrlrHFms2BxPRpInodxiMs4jrZ KxMri/whsDfGT/R4l9QbKpwx+ubW/Taw+sV7JKtzEuTpOpK6cmhmchnV9Xf9WOpbKRD4 7c8z28C79/LnmG2VyeeOoZcdZkG1aj7Vs7na1NJqAJN5IxehYcjryoAIm/ek2OKbC7m2 4eGw== X-Forwarded-Encrypted: i=1; AJvYcCUplphmsqO4qBTrxQZgViYGZyxAmbLI3m9/yRsXbpL0cf7o9/osy1zgyLoVsShRJ5m3ZrKrVH0=@vger.kernel.org X-Gm-Message-State: AOJu0YyElITlc0SYlgFQp24iAwqy3F5OY9IPzeA9JIKrCNm0c3+VAWLs +9Ii6O92YyrqNJ7kkjkDY5eCBq1BnpRPhF4JBZx101ylBoc0AbBlcmkdRRair5I8dzsXNoKOZsr n9VL50UiOtnWNU7vd2av9SpTIYWgVJpgWonmLALVWE6tMrtbiYkTjukxl6w== X-Gm-Gg: AY/fxX7R4vwIIqUn9nI7T6rA8CBiyu4OiybdVMLdzHJAW6TqKww/zF0g88NU42hLWvX ztfD4C/7QJcrQD0DltUEemWcusOQ8QHUVKuwozpJPGqmOiW5NpZcRQea25UwtPGvKyiICeU8wOZ 0KVyeMQCCbnFZ45MaXVeD76KHMsqNxE0fY1oVWZt39JcO96yELVewS0QWStiVOXoM7LSkgYfbyS re31XiJtVsORbF4fepewxd7jwUvSG2KgvT+yAhUIT4qkgOwR8ECLnM/MnIf6sQA3yFVpLJYxKWY 3FvsnywhObBzAddOZih3/IvfYFNMaqslZvQojgtnCMPzFl5loth0MojDqKoJStS9A0eBida2Rko Xlv3nq1KSqQfS0nAAJhZZcY79pu1c68aFag== X-Received: by 2002:a05:6000:220b:b0:430:fbce:f382 with SMTP id ffacd0b85a97d-4324e4d04d4mr58561443f8f.25.1767601401648; Mon, 05 Jan 2026 00:23:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IGx1Nl8KRgrNe9z8PJkEy+oAdnaqu11UpBKN0xrzW8x/NIJB12I9Y53VIEzJyG5l7t+8XCSPQ== X-Received: by 2002:a05:6000:220b:b0:430:fbce:f382 with SMTP id ffacd0b85a97d-4324e4d04d4mr58561401f8f.25.1767601401124; Mon, 05 Jan 2026 00:23:21 -0800 (PST) Received: from redhat.com (IGLD-80-230-31-118.inter.net.il. [80.230.31.118]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4324eaa4749sm100730503f8f.37.2026.01.05.00.23.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jan 2026 00:23:20 -0800 (PST) Date: Mon, 5 Jan 2026 03:23:17 -0500 From: "Michael S. Tsirkin" To: linux-kernel@vger.kernel.org Cc: Cong Wang , Jonathan Corbet , Olivia Mackall , Herbert Xu , Jason Wang , Paolo Bonzini , Stefan Hajnoczi , Eugenio =?utf-8?B?UMOpcmV6?= , "James E.J. Bottomley" , "Martin K. Petersen" , Gerd Hoffmann , Xuan Zhuo , Marek Szyprowski , Robin Murphy , Stefano Garzarella , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Petr Tesarik , Leon Romanovsky , Jason Gunthorpe , Bartosz Golaszewski , linux-doc@vger.kernel.org, linux-crypto@vger.kernel.org, virtualization@lists.linux.dev, linux-scsi@vger.kernel.org, iommu@lists.linux.dev, kvm@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v2 07/15] vsock/virtio: fix DMA alignment for event_list Message-ID: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailer: git-send-email 2.27.0.106.g8ac3dc51b1 X-Mutt-Fcc: =sent On non-cache-coherent platforms, when a structure contains a buffer used for DMA alongside fields that the CPU writes to, cacheline sharing can cause data corruption. The event_list array is used for DMA_FROM_DEVICE operations via virtqueue_add_inbuf(). The adjacent event_run and guest_cid fields are written by the CPU while the buffer is available, so mapped for the device. If these share cachelines with event_list, CPU writes can corrupt DMA data. Add __dma_from_device_group_begin()/end() annotations to ensure event_list is isolated in its own cachelines. Signed-off-by: Michael S. Tsirkin --- net/vmw_vsock/virtio_transport.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c index 8c867023a2e5..bb94baadfd8b 100644 --- a/net/vmw_vsock/virtio_transport.c +++ b/net/vmw_vsock/virtio_transport.c @@ -17,6 +17,7 @@ #include #include #include +#include #include #include #include @@ -59,8 +60,9 @@ struct virtio_vsock { */ struct mutex event_lock; bool event_run; + __dma_from_device_group_begin(); struct virtio_vsock_event event_list[8]; - + __dma_from_device_group_end(); u32 guest_cid; bool seqpacket_allow; -- MST