From: David Ahern <dsahern@gmail.com>
To: Ido Schimmel <idosch@nvidia.com>, netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, amcohen@nvidia.com
Subject: Re: [PATCH net 3/3] selftests: netdevsim: Add test cases for route deletion failure
Date: Thu, 28 Jul 2022 08:53:59 -0600 [thread overview]
Message-ID: <f1a52282-fab6-7b71-dd89-fe647c7eec6b@gmail.com> (raw)
In-Reply-To: <20220728114535.3318119-4-idosch@nvidia.com>
On 7/28/22 5:45 AM, Ido Schimmel wrote:
> Add IPv4 and IPv6 test cases that ensure that we are not leaking a
> reference on the nexthop device when we are unable to delete its
> associated route.
>
> Without the fix in a previous patch ("netdevsim: fib: Fix reference
> count leak on route deletion failure") both test cases get stuck,
> waiting for the reference to be released from the dummy device [1][2].
>
...
>
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>
> Reviewed-by: Amit Cohen <amcohen@nvidia.com>
> ---
> .../selftests/drivers/net/netdevsim/fib.sh | 45 +++++++++++++++++++
> 1 file changed, 45 insertions(+)
>
Reviewed-by: David Ahern <dsahern@kernel.org>
next prev parent reply other threads:[~2022-07-28 14:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 11:45 [PATCH net 0/3] netdevsim: fib: Fix reference count leak on route deletion failure Ido Schimmel
2022-07-28 11:45 ` [PATCH net 1/3] " Ido Schimmel
2022-07-28 15:21 ` David Ahern
2022-07-28 11:45 ` [PATCH net 2/3] netdevsim: fib: Add debugfs knob to simulate " Ido Schimmel
2022-07-28 14:51 ` David Ahern
2022-07-28 11:45 ` [PATCH net 3/3] selftests: netdevsim: Add test cases for " Ido Schimmel
2022-07-28 14:53 ` David Ahern [this message]
2022-07-29 5:07 ` [PATCH net 0/3] netdevsim: fib: Fix reference count leak on " Jakub Kicinski
2022-07-29 11:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1a52282-fab6-7b71-dd89-fe647c7eec6b@gmail.com \
--to=dsahern@gmail.com \
--cc=amcohen@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).