From: Florian Fainelli <f.fainelli@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, andrew@lunn.ch, l.stach@pengutronix.de,
fugang.duan@nxp.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: fec: Fix unbalanced PM runtime calls
Date: Sun, 18 Mar 2018 14:42:22 -0700 [thread overview]
Message-ID: <f1ba3f3e-adef-c7f0-d9b2-47bbdade91f5@gmail.com> (raw)
In-Reply-To: <20180318.163501.2001276876693998811.davem@davemloft.net>
On 03/18/2018 01:35 PM, David Miller wrote:
> From: Florian Fainelli <f.fainelli@gmail.com>
> Date: Sun, 18 Mar 2018 12:49:51 -0700
>
>> When unbinding/removing the driver, we will run into the following warnings:
>>
>> [ 259.655198] fec 400d1000.ethernet: 400d1000.ethernet supply phy not found, using dummy regulator
>> [ 259.665065] fec 400d1000.ethernet: Unbalanced pm_runtime_enable!
>> [ 259.672770] fec 400d1000.ethernet (unnamed net_device) (uninitialized): Invalid MAC address: 00:00:00:00:00:00
>> [ 259.683062] fec 400d1000.ethernet (unnamed net_device) (uninitialized): Using random MAC address: f2:3e:93:b7:29:c1
>> [ 259.696239] libphy: fec_enet_mii_bus: probed
>>
>> Avoid these warnings by balancing the runtime PM calls during fec_drv_remove().
>>
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>
> Applied, thank you.
>
> Queue this up for -stable?
I would be inclined to say yes, it was not exactly easy to track down a
set of commits, since this was changed quite a bit.
--
Florian
next prev parent reply other threads:[~2018-03-18 21:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-18 19:49 [PATCH net] net: fec: Fix unbalanced PM runtime calls Florian Fainelli
2018-03-18 20:35 ` David Miller
2018-03-18 21:42 ` Florian Fainelli [this message]
2018-03-19 0:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1ba3f3e-adef-c7f0-d9b2-47bbdade91f5@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=fugang.duan@nxp.com \
--cc=l.stach@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).