From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5162C43381 for ; Sun, 3 Mar 2019 16:12:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7691C2075B for ; Sun, 3 Mar 2019 16:12:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kZtYzH0l" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726447AbfCCQMq (ORCPT ); Sun, 3 Mar 2019 11:12:46 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:43442 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726387AbfCCQMq (ORCPT ); Sun, 3 Mar 2019 11:12:46 -0500 Received: by mail-wr1-f66.google.com with SMTP id d17so2850333wre.10 for ; Sun, 03 Mar 2019 08:12:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=BSNsLw13K3xBQRK+64+Cp88O4CIBzmxsRp4pXBB9k00=; b=kZtYzH0lAJJGw0DJzTb+iKmMysXiV1oykfP4seE6EOt64BBGrXK+aQdgdHOb3hbaqY fRbjgTJWP7PBvGfA+XlLI9vSRH1uEJsj/ft+JhPi8xO9W4hml9tcC/+w5Hnd4hnsm5YH M+mT4TVs6yqYdoQWnFS8PAzgBU+3mF/zPCgucJ6cHWAFadX+L+ng4412zmh7+s2lPNza Q9rETpnpLbt3NxonwOqZ8SYS/Fjn0jGrFjYRPCyijyzRJkAbdA1t3bEYXmi/fOl1u8PF a7DPJCv9P79/sfPWX1347oN58AeB8OFC+cxoZy1lrROYCWOeY5BYnOh7aH1qc1CO8ykx 1MYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=BSNsLw13K3xBQRK+64+Cp88O4CIBzmxsRp4pXBB9k00=; b=qSTsaJZwpD4A/gybkza1sGvN4LcWEoE2WFDgP52uzTRXHEW9Wywn+W2TaU9Ca8RyNX shqn+C45sSZM6SLN4eUIR6ijIjJyBlKado8H9EROuqW3cnvz0k28c7qHiO5qZXLxfAT/ zlB87Lcng4fBwpziR0MykRKBDeIVKJ6/X7SZWoMFC3I/9RmJIFD9z3X2pN5TVbKPYm3Q FPPtM/ISBVq+K4EkVcmAhoBFgoawJpYYPw9yjGcB01Q9vSqpCRI1SPBCd/fkgmoQDVvk bwHakXUMQJy+8OOQvEmkQes6pkG7li9EldXI1P18RtVQZ1TsMcIsBGiVfTr7axQe6Pdu HLEA== X-Gm-Message-State: APjAAAVhpMcBd9jiV4EkR08r5clxxE23hHTlhUQ1CSS6NoDN0TOAMexG jyRoPTHMf4mvoqZEhiMDjlpeFoM6 X-Google-Smtp-Source: APXvYqzr4DHD5fWZicIFZM0pXnNEmLHNBO2KPglu/p1+LmwZ7EqFEMP0KK73c6RIr2ksaOzvWH3k2w== X-Received: by 2002:adf:9004:: with SMTP id h4mr10397867wrh.49.1551629563597; Sun, 03 Mar 2019 08:12:43 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:35a8:f48d:4b19:96c9? (p200300EA8BF1E20035A8F48D4B1996C9.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:35a8:f48d:4b19:96c9]) by smtp.googlemail.com with ESMTPSA id v2sm5599162wme.29.2019.03.03.08.12.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 03 Mar 2019 08:12:42 -0800 (PST) Subject: Re: [PATCH net-next 4/5] net: phy: don't export gen10g_read_status To: Andrew Lunn Cc: Florian Fainelli , David Miller , "netdev@vger.kernel.org" References: <7c0ef5fe-2f4f-d365-a028-d96179e9fab4@gmail.com> <20190303155817.GF11621@lunn.ch> From: Heiner Kallweit Message-ID: Date: Sun, 3 Mar 2019 17:12:38 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190303155817.GF11621@lunn.ch> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 03.03.2019 16:58, Andrew Lunn wrote: > On Sat, Mar 02, 2019 at 05:15:56PM +0100, Heiner Kallweit wrote: >> gen10g_read_status is deprecated, therefore stop exporting it. >> We don't want to encourage anybody to use it. > > Hi Florian, Heiner > Hi Andrew, > We should consider what we want to do with the generic 10G driver. > > Can a c45 PHY be expected to work using a generic driver? We know > 1000BaseT is not going to work, that needs vendor registers. But the > rest might? > I think so. When looking at the Aquantia driver it should work with reduced functionality with a generic c45 driver. > I think we either need to drop the generic 10G driver, or make it use > all the new code which has been added over the last month. > Not sure whether anybody is relying on the gen10g driver currently. I'd say we could replace gen10g with a genc45 driver. It could provide the basic functionality for a new C45 PHY model until there's a dedicated PHY driver supporting the vendor-specific stuff and 1000BaseT. > Andrew > Heiner