From: Mateusz Polchlopek <mateusz.polchlopek@intel.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <intel-wired-lan@lists.osuosl.org>, <apw@canonical.com>,
<joe@perches.com>, <dwaipayanray1@gmail.com>,
<lukas.bulwahn@gmail.com>, <akpm@linux-foundation.org>,
<willemb@google.com>, <edumazet@google.com>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Igor Bagnucki <igor.bagnucki@intel.com>,
Wojciech Drewek <wojciech.drewek@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2 3/6] ice: add Tx hang devlink health reporter
Date: Tue, 30 Jul 2024 11:33:34 +0200 [thread overview]
Message-ID: <f1ea076c-e576-417c-9ecc-abb4aa7ebff7@intel.com> (raw)
In-Reply-To: <f1eb7226-0af7-4475-a57d-e3293dbc1071@intel.com>
On 7/22/2024 11:23 AM, Mateusz Polchlopek wrote:
>
>
> On 7/14/2024 4:23 PM, Jakub Kicinski wrote:
>> On Fri, 12 Jul 2024 05:32:48 -0400 Mateusz Polchlopek wrote:
>>> + err = devlink_health_report(reporter, msg, priv_ctx);
>>> + if (err) {
>>> + struct ice_pf *pf = devlink_health_reporter_priv(reporter);
>>> +
>>> + dev_err(ice_pf_to_dev(pf),
>>> + "failed to report %s via devlink health, err %d\n",
>>> + msg, err);
>>
>> My knee-jerk reaction is - why not put it in devlink_health_report()?
>> Also, I'd rate limit the message.
>
> Hmmm... That's good point. I will talk to the author about that but
> seems to be good point Jakub.
>
I took a look into the code and it seems that we do not do auto
recovering, so also ignoring return value which always will be 0.
I will remove this error checking in v3 version.
next prev parent reply other threads:[~2024-07-30 9:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-12 9:32 [Intel-wired-lan] [PATCH iwl-next v2 0/6] Add support for devlink health events Mateusz Polchlopek
2024-07-12 9:32 ` [Intel-wired-lan] [PATCH iwl-next v2 1/6] checkpatch: don't complain on _Generic() use Mateusz Polchlopek
2024-07-12 9:32 ` [Intel-wired-lan] [PATCH iwl-next v2 2/6] devlink: add devlink_fmsg_put() macro Mateusz Polchlopek
2024-07-12 9:32 ` [Intel-wired-lan] [PATCH iwl-next v2 3/6] ice: add Tx hang devlink health reporter Mateusz Polchlopek
2024-07-14 14:23 ` Jakub Kicinski
2024-07-22 9:23 ` Mateusz Polchlopek
2024-07-30 9:33 ` Mateusz Polchlopek [this message]
2024-07-12 9:32 ` [Intel-wired-lan] [PATCH iwl-next v2 4/6] ice: print ethtool stats as part of " Mateusz Polchlopek
2024-07-12 9:32 ` [Intel-wired-lan] [PATCH iwl-next v2 5/6] ice: Add MDD logging via devlink health Mateusz Polchlopek
2024-07-12 9:32 ` [Intel-wired-lan] [PATCH iwl-next v2 6/6] ice: devlink health: dump also skb on Tx hang Mateusz Polchlopek
2024-07-14 14:30 ` Jakub Kicinski
2024-07-22 9:23 ` Mateusz Polchlopek
2024-07-30 9:35 ` Mateusz Polchlopek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1ea076c-e576-417c-9ecc-abb4aa7ebff7@intel.com \
--to=mateusz.polchlopek@intel.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=dwaipayanray1@gmail.com \
--cc=edumazet@google.com \
--cc=igor.bagnucki@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=joe@perches.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
--cc=willemb@google.com \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).