From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54544C73C53 for ; Tue, 9 Jul 2019 20:36:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2CBE52166E for ; Tue, 9 Jul 2019 20:36:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XgyJHtmn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729441AbfGIUgh (ORCPT ); Tue, 9 Jul 2019 16:36:37 -0400 Received: from mail-io1-f67.google.com ([209.85.166.67]:44399 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729179AbfGIUgh (ORCPT ); Tue, 9 Jul 2019 16:36:37 -0400 Received: by mail-io1-f67.google.com with SMTP id s7so46037766iob.11 for ; Tue, 09 Jul 2019 13:36:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=6m7K62uIkNdn9JzBs9gvpn8zso5q4eFW2shRH6A/EWk=; b=XgyJHtmnh8xT3uxM453EwoHyGyyl/430CnJfU1twLQt+DCfY6Jom3M6tTraGwILW8C oqmKhDwz3xjgsD/3ZJYvOc951HF2N56lr9Mwo8amir4P+wAdXswHHyQbayPcnXgy2sIg oPEciUlvHqmxeVWZ1vwzwPjEYw5LyALBfab6I82wdM2lx7eCvZNnmU/ezOhnO4MNh9Jl zlXF49LAPA+A27t6+uJSblhltWzX4VpydgygnEL7OAYGcd3POylTYbVbGWLjyxjFTEPQ xx0Np+vsJXcHbP8RIYQ0vnAl0BbrhsDvelyqXK0psNfN0sNyAgARBm9UtEx1m5r6pasG ZP1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6m7K62uIkNdn9JzBs9gvpn8zso5q4eFW2shRH6A/EWk=; b=ZGG8hsKUFGPoJnOYEgXbf+btk0nEngWHuXHrp3KllhPRy093S5QRKchdJdj8UVppJe fqcAifjNRJ5XYvDXst+GOgtPxTazTnbw3MBST3TfZ5RiKdATRCO4FtgOHoXJ8yYKIg4w xea7djfsGgQAuitZXWkJuPHadlTRkwGR4m41esaEJ+0UniYnmVzhblrQA8+hS+Hyc5TR MBFVT9l7qLZQ2kcXdlZaepn5nQSvPDqCwZ0TifH4j+Q9aQvZZ8iafs4oOXIFcpxrbx2X RI7xNbhifXN8dR7pqhpR3yczMPt+wv5XJ//EItmtNIOJzaWREKRwLR7rJQJ/H+qL6Qyu FlRg== X-Gm-Message-State: APjAAAW1GOe9gXI/RR2vh711UDVxdrpQqK4Y5Vn9Q16A4zp3DNRvzIsb 2sjs/0n4aKXN3kgJRqR3tqY= X-Google-Smtp-Source: APXvYqx1tHR0/2y3kES9wXX6DCbBYY3LVsXKtpkJljYL7p+IIMlixEky1yt3F/HmBLmF9me0fbridQ== X-Received: by 2002:a02:b78a:: with SMTP id f10mr31298823jam.5.1562704596271; Tue, 09 Jul 2019 13:36:36 -0700 (PDT) Received: from ?IPv6:2601:282:800:fd80:c0e1:11bc:b0c5:7f? ([2601:282:800:fd80:c0e1:11bc:b0c5:7f]) by smtp.googlemail.com with ESMTPSA id m4sm35229735iok.68.2019.07.09.13.36.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Jul 2019 13:36:35 -0700 (PDT) Subject: Re: [PATCH iproute2-next 2/3] tc: add mpls actions To: Stephen Hemminger , John Hurley Cc: netdev@vger.kernel.org, davem@davemloft.net, jiri@mellanox.com, xiyou.wangcong@gmail.com, willemdebruijn.kernel@gmail.com, simon.horman@netronome.com, jakub.kicinski@netronome.com, oss-drivers@netronome.com References: <1562687972-23549-1-git-send-email-john.hurley@netronome.com> <1562687972-23549-3-git-send-email-john.hurley@netronome.com> <20190709100051.65bd159d@hermes.lan> From: David Ahern Message-ID: Date: Tue, 9 Jul 2019 14:36:34 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190709100051.65bd159d@hermes.lan> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 7/9/19 11:00 AM, Stephen Hemminger wrote: > On Tue, 9 Jul 2019 16:59:31 +0100 > John Hurley wrote: > >> if (!tb[TCA_MPLS_PARMS]) { >> + print_string(PRINT_FP, NULL, "%s", "[NULL mpls parameters]"); > > This is an error message please just use fprintf(stderr instead > skbedit, nat as 2 examples (and the only 2 I checked) do the print_string.