* [PATCH] selftests:net change ifconfig with ip command
@ 2023-10-22 11:31 Swarup Laxman Kotiaklapudi
2023-10-22 17:50 ` David Ahern
0 siblings, 1 reply; 7+ messages in thread
From: Swarup Laxman Kotiaklapudi @ 2023-10-22 11:31 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni, shuah, netdev, linux-kselftest,
linux-kernel, linux-kernel-mentees
Cc: Swarup Laxman Kotiaklapudi
Change ifconfig with ip command,
on a system where ifconfig is
not used this script will not
work correcly.
Test result with this patchset:
sudo make TARGETS="net" kselftest
....
TAP version 13
1..1
timeout set to 1500
selftests: net: route_localnet.sh
run arp_announce test
net.ipv4.conf.veth0.route_localnet = 1
net.ipv4.conf.veth1.route_localnet = 1
net.ipv4.conf.veth0.arp_announce = 2
net.ipv4.conf.veth1.arp_announce = 2
PING 127.25.3.14 (127.25.3.14) from 127.25.3.4 veth0: 56(84)
bytes of data.
64 bytes from 127.25.3.14: icmp_seq=1 ttl=64 time=0.038 ms
64 bytes from 127.25.3.14: icmp_seq=2 ttl=64 time=0.068 ms
64 bytes from 127.25.3.14: icmp_seq=3 ttl=64 time=0.068 ms
64 bytes from 127.25.3.14: icmp_seq=4 ttl=64 time=0.068 ms
64 bytes from 127.25.3.14: icmp_seq=5 ttl=64 time=0.068 ms
--- 127.25.3.14 ping statistics ---
5 packets transmitted, 5 received, 0% packet loss, time 4073ms
rtt min/avg/max/mdev = 0.038/0.062/0.068/0.012 ms
ok
run arp_ignore test
net.ipv4.conf.veth0.route_localnet = 1
net.ipv4.conf.veth1.route_localnet = 1
net.ipv4.conf.veth0.arp_ignore = 3
net.ipv4.conf.veth1.arp_ignore = 3
PING 127.25.3.14 (127.25.3.14) from 127.25.3.4 veth0: 56(84)
bytes of data.
64 bytes from 127.25.3.14: icmp_seq=1 ttl=64 time=0.032 ms
64 bytes from 127.25.3.14: icmp_seq=2 ttl=64 time=0.065 ms
64 bytes from 127.25.3.14: icmp_seq=3 ttl=64 time=0.066 ms
64 bytes from 127.25.3.14: icmp_seq=4 ttl=64 time=0.065 ms
64 bytes from 127.25.3.14: icmp_seq=5 ttl=64 time=0.065 ms
--- 127.25.3.14 ping statistics ---
5 packets transmitted, 5 received, 0% packet loss, time 4092ms
rtt min/avg/max/mdev = 0.032/0.058/0.066/0.013 ms
ok
ok 1 selftests: net: route_localnet.sh
...
Signed-off-by: Swarup Laxman Kotiaklapudi <swarupkotikalapudi@gmail.com>
---
tools/testing/selftests/net/route_localnet.sh | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/net/route_localnet.sh b/tools/testing/selftests/net/route_localnet.sh
index 116bfeab72fa..3ab9beb4462c 100755
--- a/tools/testing/selftests/net/route_localnet.sh
+++ b/tools/testing/selftests/net/route_localnet.sh
@@ -18,8 +18,10 @@ setup() {
ip route del 127.0.0.0/8 dev lo table local
ip netns exec "${PEER_NS}" ip route del 127.0.0.0/8 dev lo table local
- ifconfig veth0 127.25.3.4/24 up
- ip netns exec "${PEER_NS}" ifconfig veth1 127.25.3.14/24 up
+ ip a add 127.25.3.4/24 dev veth0
+ ip link set dev veth0 up
+ ip netns exec "${PEER_NS}" ip a add 127.25.3.14/24 dev veth1
+ ip netns exec "${PEER_NS}" ip link set dev veth1 up
ip route flush cache
ip netns exec "${PEER_NS}" ip route flush cache
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] selftests:net change ifconfig with ip command
2023-10-22 11:31 [PATCH] selftests:net change ifconfig with ip command Swarup Laxman Kotiaklapudi
@ 2023-10-22 17:50 ` David Ahern
2023-10-23 7:12 ` Jiri Pirko
0 siblings, 1 reply; 7+ messages in thread
From: David Ahern @ 2023-10-22 17:50 UTC (permalink / raw)
To: Swarup Laxman Kotiaklapudi, davem, edumazet, kuba, pabeni, shuah,
netdev, linux-kselftest, linux-kernel, linux-kernel-mentees
On 10/22/23 5:31 AM, Swarup Laxman Kotiaklapudi wrote:
> diff --git a/tools/testing/selftests/net/route_localnet.sh b/tools/testing/selftests/net/route_localnet.sh
> index 116bfeab72fa..3ab9beb4462c 100755
> --- a/tools/testing/selftests/net/route_localnet.sh
> +++ b/tools/testing/selftests/net/route_localnet.sh
> @@ -18,8 +18,10 @@ setup() {
> ip route del 127.0.0.0/8 dev lo table local
> ip netns exec "${PEER_NS}" ip route del 127.0.0.0/8 dev lo table local
>
> - ifconfig veth0 127.25.3.4/24 up
> - ip netns exec "${PEER_NS}" ifconfig veth1 127.25.3.14/24 up
> + ip a add 127.25.3.4/24 dev veth0
ip addr add ...
> + ip link set dev veth0 up
> + ip netns exec "${PEER_NS}" ip a add 127.25.3.14/24 dev veth1
ip addr add ...
> + ip netns exec "${PEER_NS}" ip link set dev veth1 up
>
> ip route flush cache
> ip netns exec "${PEER_NS}" ip route flush cache
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] selftests:net change ifconfig with ip command
2023-10-22 17:50 ` David Ahern
@ 2023-10-23 7:12 ` Jiri Pirko
2023-10-23 12:34 ` [PATCH v2] " Swarup Laxman Kotiaklapudi
2023-10-23 14:19 ` [PATCH] " David Ahern
0 siblings, 2 replies; 7+ messages in thread
From: Jiri Pirko @ 2023-10-23 7:12 UTC (permalink / raw)
To: David Ahern
Cc: Swarup Laxman Kotiaklapudi, davem, edumazet, kuba, pabeni, shuah,
netdev, linux-kselftest, linux-kernel, linux-kernel-mentees
Sun, Oct 22, 2023 at 07:50:52PM CEST, dsahern@kernel.org wrote:
>On 10/22/23 5:31 AM, Swarup Laxman Kotiaklapudi wrote:
>> diff --git a/tools/testing/selftests/net/route_localnet.sh b/tools/testing/selftests/net/route_localnet.sh
>> index 116bfeab72fa..3ab9beb4462c 100755
>> --- a/tools/testing/selftests/net/route_localnet.sh
>> +++ b/tools/testing/selftests/net/route_localnet.sh
>> @@ -18,8 +18,10 @@ setup() {
>> ip route del 127.0.0.0/8 dev lo table local
>> ip netns exec "${PEER_NS}" ip route del 127.0.0.0/8 dev lo table local
>>
>> - ifconfig veth0 127.25.3.4/24 up
>> - ip netns exec "${PEER_NS}" ifconfig veth1 127.25.3.14/24 up
>> + ip a add 127.25.3.4/24 dev veth0
>
>ip addr add ...
Why not "address" then? :)
What's wrong with "a"?
>
>> + ip link set dev veth0 up
>> + ip netns exec "${PEER_NS}" ip a add 127.25.3.14/24 dev veth1
>
>ip addr add ...
>
>> + ip netns exec "${PEER_NS}" ip link set dev veth1 up
>>
>> ip route flush cache
>> ip netns exec "${PEER_NS}" ip route flush cache
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH v2] selftests:net change ifconfig with ip command
2023-10-23 7:12 ` Jiri Pirko
@ 2023-10-23 12:34 ` Swarup Laxman Kotiaklapudi
2023-10-23 14:18 ` David Ahern
2023-10-24 21:00 ` patchwork-bot+netdevbpf
2023-10-23 14:19 ` [PATCH] " David Ahern
1 sibling, 2 replies; 7+ messages in thread
From: Swarup Laxman Kotiaklapudi @ 2023-10-23 12:34 UTC (permalink / raw)
To: davem, jiri, edumazet, kuba, pabeni, shuah, netdev,
linux-kselftest, linux-kernel, linux-kernel-mentees
Cc: Swarup Laxman Kotiaklapudi
Change ifconfig with ip command,
on a system where ifconfig is
not used this script will not
work correcly.
Test result with this patchset:
sudo make TARGETS="net" kselftest
....
TAP version 13
1..1
timeout set to 1500
selftests: net: route_localnet.sh
run arp_announce test
net.ipv4.conf.veth0.route_localnet = 1
net.ipv4.conf.veth1.route_localnet = 1
net.ipv4.conf.veth0.arp_announce = 2
net.ipv4.conf.veth1.arp_announce = 2
PING 127.25.3.14 (127.25.3.14) from 127.25.3.4 veth0: 56(84)
bytes of data.
64 bytes from 127.25.3.14: icmp_seq=1 ttl=64 time=0.038 ms
64 bytes from 127.25.3.14: icmp_seq=2 ttl=64 time=0.068 ms
64 bytes from 127.25.3.14: icmp_seq=3 ttl=64 time=0.068 ms
64 bytes from 127.25.3.14: icmp_seq=4 ttl=64 time=0.068 ms
64 bytes from 127.25.3.14: icmp_seq=5 ttl=64 time=0.068 ms
--- 127.25.3.14 ping statistics ---
5 packets transmitted, 5 received, 0% packet loss, time 4073ms
rtt min/avg/max/mdev = 0.038/0.062/0.068/0.012 ms
ok
run arp_ignore test
net.ipv4.conf.veth0.route_localnet = 1
net.ipv4.conf.veth1.route_localnet = 1
net.ipv4.conf.veth0.arp_ignore = 3
net.ipv4.conf.veth1.arp_ignore = 3
PING 127.25.3.14 (127.25.3.14) from 127.25.3.4 veth0: 56(84)
bytes of data.
64 bytes from 127.25.3.14: icmp_seq=1 ttl=64 time=0.032 ms
64 bytes from 127.25.3.14: icmp_seq=2 ttl=64 time=0.065 ms
64 bytes from 127.25.3.14: icmp_seq=3 ttl=64 time=0.066 ms
64 bytes from 127.25.3.14: icmp_seq=4 ttl=64 time=0.065 ms
64 bytes from 127.25.3.14: icmp_seq=5 ttl=64 time=0.065 ms
--- 127.25.3.14 ping statistics ---
5 packets transmitted, 5 received, 0% packet loss, time 4092ms
rtt min/avg/max/mdev = 0.032/0.058/0.066/0.013 ms
ok
ok 1 selftests: net: route_localnet.sh
...
Signed-off-by: Swarup Laxman Kotiaklapudi <swarupkotikalapudi@gmail.com>
---
tools/testing/selftests/net/route_localnet.sh | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/net/route_localnet.sh b/tools/testing/selftests/net/route_localnet.sh
index 116bfeab72fa..e08701c750e3 100755
--- a/tools/testing/selftests/net/route_localnet.sh
+++ b/tools/testing/selftests/net/route_localnet.sh
@@ -18,8 +18,10 @@ setup() {
ip route del 127.0.0.0/8 dev lo table local
ip netns exec "${PEER_NS}" ip route del 127.0.0.0/8 dev lo table local
- ifconfig veth0 127.25.3.4/24 up
- ip netns exec "${PEER_NS}" ifconfig veth1 127.25.3.14/24 up
+ ip address add 127.25.3.4/24 dev veth0
+ ip link set dev veth0 up
+ ip netns exec "${PEER_NS}" ip address add 127.25.3.14/24 dev veth1
+ ip netns exec "${PEER_NS}" ip link set dev veth1 up
ip route flush cache
ip netns exec "${PEER_NS}" ip route flush cache
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v2] selftests:net change ifconfig with ip command
2023-10-23 12:34 ` [PATCH v2] " Swarup Laxman Kotiaklapudi
@ 2023-10-23 14:18 ` David Ahern
2023-10-24 21:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 7+ messages in thread
From: David Ahern @ 2023-10-23 14:18 UTC (permalink / raw)
To: Swarup Laxman Kotiaklapudi, davem, jiri, edumazet, kuba, pabeni,
shuah, netdev, linux-kselftest, linux-kernel,
linux-kernel-mentees
On 10/23/23 6:34 AM, Swarup Laxman Kotiaklapudi wrote:
> Change ifconfig with ip command,
> on a system where ifconfig is
> not used this script will not
> work correcly.
>
> Test result with this patchset:
>
> sudo make TARGETS="net" kselftest
> ....
> TAP version 13
> 1..1
> timeout set to 1500
> selftests: net: route_localnet.sh
> run arp_announce test
> net.ipv4.conf.veth0.route_localnet = 1
> net.ipv4.conf.veth1.route_localnet = 1
> net.ipv4.conf.veth0.arp_announce = 2
> net.ipv4.conf.veth1.arp_announce = 2
> PING 127.25.3.14 (127.25.3.14) from 127.25.3.4 veth0: 56(84)
> bytes of data.
> 64 bytes from 127.25.3.14: icmp_seq=1 ttl=64 time=0.038 ms
> 64 bytes from 127.25.3.14: icmp_seq=2 ttl=64 time=0.068 ms
> 64 bytes from 127.25.3.14: icmp_seq=3 ttl=64 time=0.068 ms
> 64 bytes from 127.25.3.14: icmp_seq=4 ttl=64 time=0.068 ms
> 64 bytes from 127.25.3.14: icmp_seq=5 ttl=64 time=0.068 ms
>
> --- 127.25.3.14 ping statistics ---
> 5 packets transmitted, 5 received, 0% packet loss, time 4073ms
> rtt min/avg/max/mdev = 0.038/0.062/0.068/0.012 ms
> ok
> run arp_ignore test
> net.ipv4.conf.veth0.route_localnet = 1
> net.ipv4.conf.veth1.route_localnet = 1
> net.ipv4.conf.veth0.arp_ignore = 3
> net.ipv4.conf.veth1.arp_ignore = 3
> PING 127.25.3.14 (127.25.3.14) from 127.25.3.4 veth0: 56(84)
> bytes of data.
> 64 bytes from 127.25.3.14: icmp_seq=1 ttl=64 time=0.032 ms
> 64 bytes from 127.25.3.14: icmp_seq=2 ttl=64 time=0.065 ms
> 64 bytes from 127.25.3.14: icmp_seq=3 ttl=64 time=0.066 ms
> 64 bytes from 127.25.3.14: icmp_seq=4 ttl=64 time=0.065 ms
> 64 bytes from 127.25.3.14: icmp_seq=5 ttl=64 time=0.065 ms
>
> --- 127.25.3.14 ping statistics ---
> 5 packets transmitted, 5 received, 0% packet loss, time 4092ms
> rtt min/avg/max/mdev = 0.032/0.058/0.066/0.013 ms
> ok
> ok 1 selftests: net: route_localnet.sh
> ...
>
> Signed-off-by: Swarup Laxman Kotiaklapudi <swarupkotikalapudi@gmail.com>
> ---
> tools/testing/selftests/net/route_localnet.sh | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/net/route_localnet.sh b/tools/testing/selftests/net/route_localnet.sh
> index 116bfeab72fa..e08701c750e3 100755
> --- a/tools/testing/selftests/net/route_localnet.sh
> +++ b/tools/testing/selftests/net/route_localnet.sh
> @@ -18,8 +18,10 @@ setup() {
> ip route del 127.0.0.0/8 dev lo table local
> ip netns exec "${PEER_NS}" ip route del 127.0.0.0/8 dev lo table local
>
> - ifconfig veth0 127.25.3.4/24 up
> - ip netns exec "${PEER_NS}" ifconfig veth1 127.25.3.14/24 up
> + ip address add 127.25.3.4/24 dev veth0
> + ip link set dev veth0 up
> + ip netns exec "${PEER_NS}" ip address add 127.25.3.14/24 dev veth1
> + ip netns exec "${PEER_NS}" ip link set dev veth1 up
>
> ip route flush cache
> ip netns exec "${PEER_NS}" ip route flush cache
Reviewed-by: David Ahern <dsahern@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v2] selftests:net change ifconfig with ip command
2023-10-23 12:34 ` [PATCH v2] " Swarup Laxman Kotiaklapudi
2023-10-23 14:18 ` David Ahern
@ 2023-10-24 21:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 7+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-10-24 21:00 UTC (permalink / raw)
To: Swarup Laxman Kotiaklapudi
Cc: davem, jiri, edumazet, kuba, pabeni, shuah, netdev,
linux-kselftest, linux-kernel, linux-kernel-mentees
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 23 Oct 2023 18:04:22 +0530 you wrote:
> Change ifconfig with ip command,
> on a system where ifconfig is
> not used this script will not
> work correcly.
>
> Test result with this patchset:
>
> [...]
Here is the summary with links:
- [v2] selftests:net change ifconfig with ip command
https://git.kernel.org/netdev/net-next/c/37a38e439d4e
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] selftests:net change ifconfig with ip command
2023-10-23 7:12 ` Jiri Pirko
2023-10-23 12:34 ` [PATCH v2] " Swarup Laxman Kotiaklapudi
@ 2023-10-23 14:19 ` David Ahern
1 sibling, 0 replies; 7+ messages in thread
From: David Ahern @ 2023-10-23 14:19 UTC (permalink / raw)
To: Jiri Pirko, David Ahern
Cc: Swarup Laxman Kotiaklapudi, davem, edumazet, kuba, pabeni, shuah,
netdev, linux-kselftest, linux-kernel, linux-kernel-mentees
On 10/23/23 1:12 AM, Jiri Pirko wrote:
>> ip addr add ...
>
> Why not "address" then? :)
no objection from me.
> What's wrong with "a"?
1-letter commands can be ambiguous. Test scripts should be clear and
obvious.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-10-24 21:00 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-22 11:31 [PATCH] selftests:net change ifconfig with ip command Swarup Laxman Kotiaklapudi
2023-10-22 17:50 ` David Ahern
2023-10-23 7:12 ` Jiri Pirko
2023-10-23 12:34 ` [PATCH v2] " Swarup Laxman Kotiaklapudi
2023-10-23 14:18 ` David Ahern
2023-10-24 21:00 ` patchwork-bot+netdevbpf
2023-10-23 14:19 ` [PATCH] " David Ahern
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).