From: Paolo Abeni <pabeni@redhat.com>
To: shuo huang <f64116045@gs.ncku.edu.tw>, netdev@vger.kernel.org
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
horms@kernel.org, shuah@kernel.org, jiayuan.chen@linux.dev
Subject: Re: [PATCH net-next v3 0/2] selftests: net: Exercise TCP payload verification
Date: Thu, 17 Sep 2026 11:37:30 +0200 [thread overview]
Message-ID: <f2444878-9676-40fd-878a-c69472229d16@redhat.com> (raw)
In-Reply-To: <20260914004525.46597-1-f64116045@gs.ncku.edu.tw>
On 9/14/26 02:45, shuo huang wrote:
> This series adds TCP payload verification to udpgso_bench_rx and
> exercises it from udpgso_bench.sh for both IPv4 and IPv6. The test
> checks the receiver's exit status so that verification errors are
> reported as test failures.
>
> Changes since v2:
> - Wrap the receiver command in patch 2 to stay within 80 columns.
>
> v2: https://lore.kernel.org/r/20260911160649.51863-1-f64116045@gs.ncku.edu.tw
>
> Changes since v1:
> - Add patch 2 to exercise the TCP verifier from udpgso_bench.sh,
> addressing Jakub's feedback.
I think you did not answer the more fundamental question there: why is
this useful? I don't see much value on top of the existing GRO (h/w)
tests, while this add a bunch of testscase/runtime/resource usage on the
CI from now on.
In the current format it's IMHO not worth merging.
/P
prev parent reply other threads:[~2026-09-17 9:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 0:45 [PATCH net-next v3 0/2] selftests: net: Exercise TCP payload verification shuo huang
2026-09-14 0:45 ` [PATCH net-next v3 1/2] selftests: net: Add TCP payload verification to udpgso_bench_rx shuo huang
2026-09-14 0:45 ` [PATCH net-next v3 2/2] selftests: net: Exercise TCP payload verification in udpgso_bench.sh shuo huang
2026-09-17 9:37 ` Paolo Abeni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2444878-9676-40fd-878a-c69472229d16@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f64116045@gs.ncku.edu.tw \
--cc=horms@kernel.org \
--cc=jiayuan.chen@linux.dev \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox