From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jamal Hadi Salim <jhs@mojatatu.com>
Subject: Re: [PATCH net-next v3 4/5] net/tc: introduce TC_ACT_REINJECT.
Date: Wed, 25 Jul 2018 08:27:22 -0400
Message-ID: <f2856833-d69c-7cef-1bf9-0d31c7cf7343@mojatatu.com>
References: <cover.1532437050.git.pabeni@redhat.com>
 <3c20787be0fd5d64728ffed46ae0a7dff10d7e05.1532437050.git.pabeni@redhat.com>
 <CAM_iQpUHjoohcMgXd8y9GVn8hdFwMRGJeCJ5wSfphModf0qZ-A@mail.gmail.com>
 <CAM_iQpWEUz8ASVkAR7-dpAOB75f5To0KL32VgaNciwx-JaqOOA@mail.gmail.com>
 <6a9fd3c8f861c203c7e12a2a2e477796c5e093d5.camel@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
        Jiri Pirko <jiri@resnulli.us>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
        Eyal Birger <eyal.birger@gmail.com>,
        David Miller <davem@davemloft.net>
To: Paolo Abeni <pabeni@redhat.com>,
        Cong Wang <xiyou.wangcong@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-io0-f195.google.com ([209.85.223.195]:43579 "EHLO
        mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1728809AbeGYNix (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 25 Jul 2018 09:38:53 -0400
Received: by mail-io0-f195.google.com with SMTP id y10-v6so6156153ioa.10
        for <netdev@vger.kernel.org>; Wed, 25 Jul 2018 05:27:25 -0700 (PDT)
In-Reply-To: <6a9fd3c8f861c203c7e12a2a2e477796c5e093d5.camel@redhat.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 25/07/18 04:29 AM, Paolo Abeni wrote:
> On Tue, 2018-07-24 at 13:50 -0700, Cong Wang wrote:

[..]
>>> I fail to understand why overlimit is increased in your case
>>> here. I guess you want to increase 'drops' instead.
>>
>> Hmm, actually the current mirred code increases overlimit too.
>> But I still don't think it makes sense.
> 
> Yep, I chose to increment 'overlimits' to preserve the current mirred
> semantic.
> 
> AFAICS, that was first introduced with:
> 
> commit 8919bc13e8d92c5b082c5c0321567383a071f5bc
> Author: Jamal Hadi Salim <jhs@mojatatu.com>
> Date:   Mon Aug 15 05:25:40 2011 +0000
> 
>      net_sched: fix port mirror/redirect stats reporting
> 
> Likely increasing 'drops' would be "better", but I'm unsure we can
> change this established behavior without affecting some user.
> 

Those changes were there from the beginning (above patch did
not introduce them).
IIRC, the reason was to distinguish between policy intended
drops and drops because of errors.

cheers,
jamal