From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 911EF3839B3 for ; Fri, 19 Jun 2026 13:12:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781874772; cv=none; b=V3mc5xf+Azt79cLFS55NNk0L3G2s2VAlnEM94kv7pCUqQOELVeprUDVEH4sKUEMhiKghFhh5byKY0mcKOaqBXv8lH7VeMwGdaKNhBXYroIo9cOgQYgHiuMA8QcBV1eqSQrLLP134AEedLKKGiTPDAqlk7j+vCmIO+zLHW7U/2wQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781874772; c=relaxed/simple; bh=Nkuj7e0uLIcw2dQ+72Ht/EJgUArLcj7dXa28YZgE0v4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LyRujzzGmNzuUuYbG9OGfs7biBbawztozOZFW7Bbug31QNUUm6Cg77vs8GC+87IVnhWXH2VY9sPMvGvScGPx2wx+v5I4iSVdV1aeBCnQ2TAhBDMyqQKF2LZjppxTY2gnUWFUie8Yq91NFzFcUfihBe2cX2AjdUeqFZkc2gtOa9A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=m2swHUjb; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m2swHUjb" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-463f1165e16so1946827f8f.0 for ; Fri, 19 Jun 2026 06:12:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781874768; x=1782479568; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cYYIAxjrT/iNiD/3UYstOUuE19cihfkCG33B5fDVbBM=; b=m2swHUjbXSoTp6MOCg72HAv5y/+zClcauNiU8Q/5IOeS+TgDn5P9BZ8BMHvDD4C1Cs xJfvaTUOTSE8Ns9RV79cjIwNdfocl5E4GZr32924oCOp6d9ycUndMPe73zI2hJFrhqLj kMtpReM53tcAEEbyg52JU054ALYJDZ98GQEe9Pdb5J7T3ntMMx1pk3vDp5KpCInqopft P0eDwLGOQJUKvFtgmEzddeB5xfFMmbM0Rvs+1dpP4bp/cgMuEVnncRwRU/pyQx0Ad73M tXDDWh/3ASLZbJspZ0VUqedfnbo2WAIeGYa7gQUpp8Jl3LTCSJ3cwxX80/cD7Ts36CDn axOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781874768; x=1782479568; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cYYIAxjrT/iNiD/3UYstOUuE19cihfkCG33B5fDVbBM=; b=K2E57g/G77y0tpVpfpgne+wB92A051P47+nkRiNDkfirq9RvKsPZwue6RVQBpdess5 BMyvBmLANURo47KMZInYAHOdrAGFYiQhQhW5JqFUmBO9ooBbjzdmc5GgIeCQmS5GmLy1 ZltAuCHz6aerhv92ojSsKeAItUvf2ajGA+37zTukTOb+fOiOVspAbCEv4r/aZb2o/JJy IxZ7zT5YR9OT0PgmAOUTX9nmqGdWXrrfV/sE0NLkZZwF23HLgyJjG/H9Mpy1wyYYK7BS kzRwIV6MipEHCL1wJ5i8Suz36a9EBQKuue2qDi5bZpYzwKEhDk5iO9+OUxF0ByXR5KLN PUdA== X-Forwarded-Encrypted: i=1; AFNElJ+tI63BJsd4x8FmpoW4kvnbhtwJgu4AlDkRXLQcjbo8dib4cL7UduHBxP3P3gAslk2LPSyPBF8=@vger.kernel.org X-Gm-Message-State: AOJu0YzzLIaHR6qcCBfXeE8wlyEdWYDrLmwpgk3PmfWmFMbxcLyUC/ic VXIt522TWtCJz7eaByrGyq+yPYEcUensF24BVRFu4HAMbKJO7cqAwfaE X-Gm-Gg: AfdE7cmIn4k+y+cw+U/jb3sqStIPfu4tJzEXd/YWxv/o33KONvk7Xl58BNMPgVvRcx2 oDYuiXDvwbWKEixEzITb06ZFGaCrs9rSgS1Kynf+lpCO5X6ZTXnQVhEDxc5WyyLlmgqnXNzN2DB McvQjmpFh/U3TLzn7b6gXI7UTPSbCycR6TJs7I+sZIeG+7hBomRYsiuj9n1Zz4YY7jxRdjD0ae8 EX4GSV8neAZyOCJFxfxpDgMHrrKcblR0Trl2FayhgkUKboR9lxjHfB5wcVNZRy1MQPYhU5+Co4m aMUgrIxWtM7T6bOhkeTVW63pJNEdeT+QK+w/JrDrU+ejZNFeyrm5Vm8T3VRSFfyG8fs1KMkhYIw eoRhiD9qp4AyTfdizM9XLp9bYSIAol83D6Fh6GOAR0x/+swZj+Mpd/v8Ac0a/BUEfUhy3JIMfb4 r721TkjhtT/YFsDRXhOYAV88QDI64LGrjkG09Ns2Lnsrlthpnzvs5NmNIPLCGfRTzEHaH2AV+fm LoWxSpDh0tcVg== X-Received: by 2002:a5d:5d8a:0:b0:460:1233:ecf2 with SMTP id ffacd0b85a97d-46508afa0eemr6766999f8f.30.1781874767770; Fri, 19 Jun 2026 06:12:47 -0700 (PDT) Received: from [192.168.1.122] (cpc159313-cmbg20-2-0-cust161.5-4.cable.virginm.net. [82.0.78.162]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4650bc42a3asm7999337f8f.31.2026.06.19.06.12.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Jun 2026 06:12:47 -0700 (PDT) Message-ID: Date: Fri, 19 Jun 2026 14:12:45 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v28 1/5] sfc: add cxl support To: alejandro.lucero-palau@amd.com, linux-cxl@vger.kernel.org, netdev@vger.kernel.org, djbw@kernel.org, edward.cree@amd.com, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, edumazet@google.com, dave.jiang@intel.com Cc: Alejandro Lucero , Jonathan Cameron , Alison Schofield , Dan Williams References: <20260618181806.118745-1-alejandro.lucero-palau@amd.com> <20260618181806.118745-2-alejandro.lucero-palau@amd.com> Content-Language: en-GB From: Edward Cree In-Reply-To: <20260618181806.118745-2-alejandro.lucero-palau@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 18/06/2026 19:18, alejandro.lucero-palau@amd.com wrote: > From: Alejandro Lucero > > Add CXL initialization based on new CXL API for accel drivers and make > it dependent on kernel CXL configuration. > > Signed-off-by: Alejandro Lucero > Reviewed-by: Jonathan Cameron > Acked-by: Edward Cree > Reviewed-by: Alison Schofield > Reviewed-by: Dan Williams > Reviewed-by: Dave Jiang ... > diff --git a/drivers/net/ethernet/sfc/net_driver.h b/drivers/net/ethernet/sfc/net_driver.h > index b98c259f672d..de3fc9537662 100644 > --- a/drivers/net/ethernet/sfc/net_driver.h > +++ b/drivers/net/ethernet/sfc/net_driver.h > @@ -1197,14 +1197,23 @@ struct efx_nic { > atomic_t n_rx_noskb_drops; > }; > > +#ifdef CONFIG_SFC_CXL > +struct efx_cxl; > +#endif > + > /** > * struct efx_probe_data - State after hardware probe > * @pci_dev: The PCI device > * @efx: Efx NIC details > + * @cxl: details of related cxl objects > + * @cxl_pio_initialised: cxl initialization outcome. > */ > struct efx_probe_data { > struct pci_dev *pci_dev; > struct efx_nic efx; > +#ifdef CONFIG_SFC_CXL > + struct efx_cxl *cxl; > +#endif > }; The documented cxl_pio_initialised member does not appear to exist. Will this not cause a kerneldoc build error?