From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 055771DA33 for ; Mon, 25 Sep 2023 20:38:14 +0000 (UTC) Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C01BBE for ; Mon, 25 Sep 2023 13:38:12 -0700 (PDT) Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-4053c6f0d55so70395195e9.0 for ; Mon, 25 Sep 2023 13:38:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695674290; x=1696279090; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=GS8jJF7dO/3L5ukzOUH/lZ/m0X12dcuVKfwLipxguJo=; b=JmeVlC2wUpsOwfaj5HszxltWRDAEp/8UESGTDc7DskmQpvgwf7MWtXthj8RmzeJ47r RKDR2dfVNQkL0MbqcSbeuoSV/Nu+CaNvk2U+3QuVoU3IVfAOdRqi8gHFTtWNbpUu22sl P04A+99NEJXmfepVmoVlBg975uZEW/MdQKE6Lo1FElUvU2ilFxRWFi+02h8E3nyKk2Ll TmB2LNlDQlX/yW9Lmubo/R9gjJL1X2ejf+thLdB2/etZrxuO5XqThLcwxxoIh8bvv0zb FM7vPfgxD2skkuTug0ZdVTD94cOD3sqDdaMRqLGuJKLjuGAHsDkhhgyAW5rY2vtkmA5R UO/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695674290; x=1696279090; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GS8jJF7dO/3L5ukzOUH/lZ/m0X12dcuVKfwLipxguJo=; b=AgbJp+jkKcu8e9/mGC4HFcoTKISP/8+FoP/1uoe1Vovlc6sYDozPTOmRAWVamdWAGj H37ypYPe3svPmI0dLXfpXDnSwmkUBOuK39CfeMpgKrk9vfQ8sCu4KgtsIJbNwkzUs6LS BuZCpsxEHRCNpd3fGUvft5Wzx+8sVXzMcl2WVCzdvgdA4gmYVZFeQj87QhglcSANXGqS QpxppjMbYARqcZlOyVwQpmKBR8kBil2wfxWZYt1s+9aqAzAro+HXP2Yp1SUuA4IoujRE TR+JFYDbB2vHvd7BmncXxFJZQlH1/CopqCgFMJVnoRp1O6pGMio4t7/EJL7PTl5lL6ii MQ9g== X-Gm-Message-State: AOJu0YwFN4aNXmuV4Q6SSmleje5SSBLD4r3DWg0W6AO6XGcgmkgTPz9Y qTQtpAuvpJexGGmpILftpcI= X-Google-Smtp-Source: AGHT+IETmTR/I0jNAnaooTkQDjju//zU1BlFGt0G6wMK162NR2lvVqcIcopP0cfINrEcDU7pgHe00g== X-Received: by 2002:a1c:7710:0:b0:3fe:1f93:8cf4 with SMTP id t16-20020a1c7710000000b003fe1f938cf4mr7115261wmi.8.1695674289831; Mon, 25 Sep 2023 13:38:09 -0700 (PDT) Received: from ?IPV6:2a01:c23:bc3d:b00:d10d:a0be:a7f8:7e5e? (dynamic-2a01-0c23-bc3d-0b00-d10d-a0be-a7f8-7e5e.c23.pool.telefonica.de. [2a01:c23:bc3d:b00:d10d:a0be:a7f8:7e5e]) by smtp.googlemail.com with ESMTPSA id v19-20020a05600c429300b004047ac770d1sm11030673wmc.8.2023.09.25.13.38.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Sep 2023 13:38:09 -0700 (PDT) Message-ID: Date: Mon, 25 Sep 2023 22:38:09 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: r8169 link up but no traffic, and watchdog error To: =?UTF-8?Q?Martin_Kj=C3=A6r_J=C3=B8rgensen?= Cc: Jakub Kicinski , netdev@vger.kernel.org, nic_swsd@realtek.com References: <87zg30a0h9.fsf@lagy.org> <20230809125805.2e3f86ac@kernel.org> <87a5taabs9.fsf@mkjws.danelec-net.lan> <4ed0991b-5473-409d-b00a-bf71f0877df5@gmail.com> <87y1guv5p7.fsf@mkjws.danelec-net.lan> <87ttriqmru.fsf@ws.c.lan> Content-Language: en-US From: Heiner Kallweit Autocrypt: addr=hkallweit1@gmail.com; keydata= xsFNBF/0ZFUBEAC0eZyktSE7ZNO1SFXL6cQ4i4g6Ah3mOUIXSB4pCY5kQ6OLKHh0FlOD5/5/ sY7IoIouzOjyFdFPnz4Bl3927ClT567hUJJ+SNaFEiJ9vadI6vZm2gcY4ExdIevYHWe1msJF MVE4yNwdS+UsPeCF/6CQQTzHc+n7DomE7fjJD5J1hOJjqz2XWe71fTvYXzxCFLwXXbBiqDC9 dNqOe5odPsa4TsWZ09T33g5n2nzTJs4Zw8fCy8rLqix/raVsqr8fw5qM66MVtdmEljFaJ9N8 /W56qGCp+H8Igk/F7CjlbWXiOlKHA25mPTmbVp7VlFsvsmMokr/imQr+0nXtmvYVaKEUwY2g 86IU6RAOuA8E0J5bD/BeyZdMyVEtX1kT404UJZekFytJZrDZetwxM/cAH+1fMx4z751WJmxQ J7mIXSPuDfeJhRDt9sGM6aRVfXbZt+wBogxyXepmnlv9K4A13z9DVLdKLrYUiu9/5QEl6fgI kPaXlAZmJsQfoKbmPqCHVRYj1lpQtDM/2/BO6gHASflWUHzwmBVZbS/XRs64uJO8CB3+V3fa cIivllReueGCMsHh6/8wgPAyopXOWOxbLsZ291fmZqIR0L5Y6b2HvdFN1Xhc+YrQ8TKK+Z4R mJRDh0wNQ8Gm89g92/YkHji4jIWlp2fwzCcx5+lZCQ1XdqAiHQARAQABzSZIZWluZXIgS2Fs bHdlaXQgPGhrYWxsd2VpdDFAZ21haWwuY29tPsLBjgQTAQgAOBYhBGxfqY/yOyXjyjJehXLe ig9U8DoMBQJf9GRVAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEHLeig9U8DoMSycQ AJbfg8HZEK0ljV4M8nvdaiNixWAufrcZ+SD8zhbxl8GispK4F3Yo+20Y3UoZ7FcIidJWUUJL axAOkpI/70YNhlqAPMsuudlAieeYZKjIv1WV5ucNZ3VJ7dC+dlVqQdAr1iD869FZXvy91KhJ wYulyCf+s4T9YgmLC6jLMBZghKIf1uhSd0NzjyCqYWbk2ZxByZHgunEShOhHPHswu3Am0ftt ePaYIHgZs+Vzwfjs8I7EuW/5/f5G9w1vibXxtGY/GXwgGGHRDjFM7RSprGOv4F5eMGh+NFUJ TU9N96PQYMwXVxnQfRXl8O6ffSVmFx4H9rovxWPKobLmqQL0WKLLVvA/aOHCcMKgfyKRcLah 57vGC50Ga8oT2K1g0AhKGkyJo7lGXkMu5yEs0m9O+btqAB261/E3DRxfI1P/tvDZpLJKtq35 dXsj6sjvhgX7VxXhY1wE54uqLLHY3UZQlmH3QF5t80MS7/KhxB1pO1Cpcmkt9hgyzH8+5org +9wWxGUtJWNP7CppY+qvv3SZtKJMKsxqk5coBGwNkMms56z4qfJm2PUtJQGjA65XWdzQACib 2iaDQoBqGZfXRdPT0tC1H5kUJuOX4ll1hI/HBMEFCcO8++Bl2wcrUsAxLzGvhINVJX2DAQaF aNetToazkCnzubKfBOyiTqFJ0b63c5dqziAgzsFNBF/0ZFUBEADF8UEZmKDl1w/UxvjeyAeX kghYkY3bkK6gcIYXdLRfJw12GbvMioSguvVzASVHG8h7NbNjk1yur6AONfbUpXKSNZ0skV8V fG+ppbaY+zQofsSMoj5gP0amwbwvPzVqZCYJai81VobefTX2MZM2Mg/ThBVtGyzV3NeCpnBa 8AX3s9rrX2XUoCibYotbbxx9afZYUFyflOc7kEpc9uJXIdaxS2Z6MnYLHsyVjiU6tzKCiVOU KJevqvzPXJmy0xaOVf7mhFSNQyJTrZpLa+tvB1DQRS08CqYtIMxRrVtC0t0LFeQGly6bOngr ircurWJiJKbSXVstLHgWYiq3/GmCSx/82ObeLO3PftklpRj8d+kFbrvrqBgjWtMH4WtK5uN5 1WJ71hWJfNchKRlaJ3GWy8KolCAoGsQMovn/ZEXxrGs1ndafu47yXOpuDAozoHTBGvuSXSZo ythk/0EAuz5IkwkhYBT1MGIAvNSn9ivE5aRnBazugy0rTRkVggHvt3/7flFHlGVGpBHxFUwb /a4UjJBPtIwa4tWR8B1Ma36S8Jk456k2n1id7M0LQ+eqstmp6Y+UB+pt9NX6t0Slw1NCdYTW gJezWTVKF7pmTdXszXGxlc9kTrVUz04PqPjnYbv5UWuDd2eyzGjrrFOsJEi8OK2d2j4FfF++ AzOMdW09JVqejQARAQABwsF2BBgBCAAgFiEEbF+pj/I7JePKMl6Fct6KD1TwOgwFAl/0ZFUC GwwACgkQct6KD1TwOgxUfg//eAoYc0Vm4NrxymfcY30UjHVD0LgSvU8kUmXxil3qhFPS7KA+ y7tgcKLHOkZkXMX5MLFcS9+SmrAjSBBV8omKoHNo+kfFx/dUAtz0lot8wNGmWb+NcHeKM1eb nwUMOEa1uDdfZeKef/U/2uHBceY7Gc6zPZPWgXghEyQMTH2UhLgeam8yglyO+A6RXCh+s6ak Wje7Vo1wGK4eYxp6pwMPJXLMsI0ii/2k3YPEJPv+yJf90MbYyQSbkTwZhrsokjQEaIfjrIk3 rQRjTve/J62WIO28IbY/mENuGgWehRlTAbhC4BLTZ5uYS0YMQCR7v9UGMWdNWXFyrOB6PjSu Trn9MsPoUc8qI72mVpxEXQDLlrd2ijEWm7Nrf52YMD7hL6rXXuis7R6zY8WnnBhW0uCfhajx q+KuARXC0sDLztcjaS3ayXonpoCPZep2Bd5xqE4Ln8/COCslP7E92W1uf1EcdXXIrx1acg21 H/0Z53okMykVs3a8tECPHIxnre2UxKdTbCEkjkR4V6JyplTS47oWMw3zyI7zkaadfzVFBxk2 lo/Tny+FX1Azea3Ce7oOnRUEZtWSsUidtIjmL8YUQFZYm+JUIgfRmSpMFq8JP4VH43GXpB/S OCrl+/xujzvoUBFV/cHKjEQYBxo+MaiQa1U54ykM2W4DnHb1UiEf5xDkFd4= In-Reply-To: <87ttriqmru.fsf@ws.c.lan> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On 25.09.2023 17:41, Martin Kjær Jørgensen wrote: > > On Mon, Sep 25 2023, Heiner Kallweit wrote: > >> On 25.09.2023 13:30, Martin Kjær Jørgensen wrote: >>> >>> On Mon, Sep 25 2023, Heiner Kallweit wrote: >>> >>> >>> There are no PCI extension cards. >>> >> >> Your BIOS signature indicates that the system is a Thinkstation P350. >> According to the Lenovo website it comes with one Intel-based network port. >> However you have additional 4 Realtek-based network ports on the mainboard? >> > > Yes. 2 PCIE cards with two Realtek ethernet controllers each. > >>>> And does the problem occur with all of your NICs? >>> >>> No, only the Realtek ones. >>> >>>> The exact NIC type might provide a hint, best provide a full dmesg log. >>> [ 1512.295490] RSP: 0018:ffffbc0240193e88 EFLAGS: 00000246 >>> [ 1512.295492] RAX: ffff998935680000 RBX: ffffdc023faa8e00 RCX: 000000000000001f >>> [ 1512.295493] RDX: 0000000000000002 RSI: ffffffffb544f718 RDI: ffffffffb543bc32 >>> [ 1512.295494] RBP: 0000000000000003 R08: 0000000000000000 R09: 0000000000000018 >>> [ 1512.295495] R10: ffff9989356b1dc4 R11: 00000000000058a8 R12: ffffffffb5d981a0 >>> [ 1512.295496] R13: 000001601bd198ef R14: 0000000000000003 R15: 0000000000000000 >>> [ 1512.295497] ? cpuidle_enter_state+0xbd/0x440 >>> [ 1512.295499] cpuidle_enter+0x2d/0x40 >>> [ 1512.295501] do_idle+0x217/0x270 >>> [ 1512.295503] cpu_startup_entry+0x1d/0x20 >>> [ 1512.295505] start_secondary+0x11a/0x140 >>> [ 1512.295508] secondary_startup_64_no_verify+0x17e/0x18b >>> [ 1512.295510] >>> [ 1512.295511] ---[ end trace 0000000000000000 ]--- >>> [ 1512.295526] r8169 0000:03:00.0: can't disable ASPM; OS doesn't have ASPM control >>> [ 1531.322039] r8169 0000:03:00.0 enp3s0: Link is Down >>> [ 1534.138489] r8169 0000:03:00.0 enp3s0: Link is Up - 1Gbps/Full - flow control rx/tx >>> [ 1538.177385] r8169 0000:03:00.0 enp3s0: Link is Down >>> [ 1566.174660] r8169 0000:03:00.0 enp3s0: Link is Up - 1Gbps/Full - flow control rx/tx >>> [ 1567.839082] r8169 0000:03:00.0 enp3s0: Link is Down >>> [ 1570.621088] r8169 0000:03:00.0 enp3s0: Link is Up - 1Gbps/Full - flow control rx/tx >>> [ 1576.294267] r8169 0000:03:00.0: can't disable ASPM; OS doesn't have ASPM control >> >> Regarding the following: Issue occurs after few seconds of link-loss. >> Was this an intentional link-down event? > > Yes, I intentionally unplug the cable at the other end for the link to go down. > >> And is issue always related to link-up after a link-loss period? >> > > Yes, it happends after cable is plugged in again, so after a link-loss period. > > >>> [ 1488.643231] r8169 0000:03:00.0 enp3s0: Link is Down >>> [ 1506.576941] r8169 0000:03:00.0 enp3s0: Link is Up - 1Gbps/Full - flow control rx/tx >>> [ 1512.295215] ------------[ cut here ]------------ >>> [ 1512.295219] NETDEV WATCHDOG: enp3s0 (r8169): transmit queue 0 timed out 5368 ms Could you please test whether the following helps? diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c index 6351a2dc1..a2fbfff5a 100644 --- a/drivers/net/ethernet/realtek/r8169_main.c +++ b/drivers/net/ethernet/realtek/r8169_main.c @@ -4596,7 +4596,9 @@ static void r8169_phylink_handler(struct net_device *ndev) if (netif_carrier_ok(ndev)) { rtl_link_chg_patch(tp); pm_request_resume(d); + netif_wake_queue(tp->dev); } else { + rtl_reset_work(tp); pm_runtime_idle(d); } -- 2.42.0