From: Florian Fainelli <f.fainelli@gmail.com>
To: "Grygorii Strashko" <grygorii.strashko@ti.com>,
"SZ Lin (林上智)" <sz.lin@moxa.com>,
"David S. Miller" <davem@davemloft.net>
Cc: Schuyler Patton <spatton@ti.com>,
Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>,
Keerthy <j-keerthy@ti.com>, Sekhar Nori <nsekhar@ti.com>,
linux-omap@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net: ethernet: ti: cpsw: add check for in-band mode setting with RGMII PHY interface
Date: Thu, 15 Mar 2018 11:29:07 -0700 [thread overview]
Message-ID: <f2a255a8-945a-6248-0c28-5ed96fbfde0b@gmail.com> (raw)
In-Reply-To: <eddbe437-8a9f-c7df-4e68-8a45c6d89cdb@ti.com>
On 03/15/2018 11:18 AM, Grygorii Strashko wrote:
>
>
> On 03/15/2018 12:39 PM, Grygorii Strashko wrote:
>>
>>
>> On 03/15/2018 11:56 AM, SZ Lin (林上智) wrote:
>>> According to AM335x TRM[1] 14.3.6.2, AM437x TRM[2] 15.3.6.2 and
>>> DRA7 TRM[3] 24.11.4.8.7.3.3, in-band mode in EXT_EN(bit18) register
>>> is only
>>> available when PHY is configured in RGMII mode with 10Mbps speed. It
>>> will
>>> cause some networking issues without RGMII mode, such as carrier sense
>>> errors and low throughput. TI also mentioned this issue in their
>>> forum[4].
>>>
>>> This patch adds the check mechanism for PHY interface with RGMII
>>> interface
>>> type, the in-band mode can only be set in RGMII mode with 10Mbps speed.
>>>
>>> References:
>>> [1]: https://www.ti.com/lit/ug/spruh73p/spruh73p.pdf
>>> [2]: http://www.ti.com/lit/ug/spruhl7h/spruhl7h.pdf
>>> [3]: http://www.ti.com/lit/ug/spruic2b/spruic2b.pdf
>>> [4]: https://e2e.ti.com/support/arm/sitara_arm/f/791/p/640765/2392155
>>>
>>> Suggested-by: Holsety Chen (陳憲輝) <Holsety.Chen@moxa.com>
>>> Signed-off-by: SZ Lin (林上智) <sz.lin@moxa.com>
>>> Signed-off-by: Schuyler Patton <spatton@ti.com>
>>> ---
>>> Changes from v1:
>>> - Use phy_interface_is_rgmii helper function
>>> - Remove blank line
>>>
>>
>> Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
>>
>
> Also could this be marked as stable material 4.9+?
This is not how it works for networking changes, just make sure you
provide a "Fixes:" tag, and David would usually take care of queueing
the change to -stable accordingly:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/networking/netdev-FAQ.txt#n148
--
Florian
next prev parent reply other threads:[~2018-03-15 18:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-15 16:56 [PATCH v2] net: ethernet: ti: cpsw: add check for in-band mode setting with RGMII PHY interface SZ Lin (林上智)
2018-03-15 17:39 ` Grygorii Strashko
2018-03-15 18:18 ` Grygorii Strashko
2018-03-15 18:29 ` Florian Fainelli [this message]
2018-03-15 19:19 ` Grygorii Strashko
2018-03-17 23:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2a255a8-945a-6248-0c28-5ed96fbfde0b@gmail.com \
--to=f.fainelli@gmail.com \
--cc=davem@davemloft.net \
--cc=grygorii.strashko@ti.com \
--cc=ivan.khoronzhuk@linaro.org \
--cc=j-keerthy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=spatton@ti.com \
--cc=sz.lin@moxa.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox