From: David Ahern <dsahern@gmail.com>
To: Leon Romanovsky <leon@kernel.org>, David Ahern <dsahern@gmail.com>
Cc: Patrisious Haddad <phaddad@nvidia.com>,
Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@nvidia.com>,
linux-netdev <netdev@vger.kernel.org>,
RDMA mailing list <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH iproute2-next v2] rdma: Add support for the netlink extack
Date: Sun, 10 Jan 2021 10:23:06 -0700 [thread overview]
Message-ID: <f2ad7596-b976-aef7-56b7-edfba3a77ba0@gmail.com> (raw)
In-Reply-To: <20210103061706.18313-1-leon@kernel.org>
On 1/2/21 11:17 PM, Leon Romanovsky wrote:
> From: Patrisious Haddad <phaddad@nvidia.com>
>
> Add support in rdma for extack errors to be received
> in userspace when sent from kernel, so now netlink extack
> error messages sent from kernel would be printed for the
> user.
>
> Signed-off-by: Patrisious Haddad <phaddad@nvidia.com>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> ---
> David,
>
> Just as a note, rdmatool is heavily influenced by the devlink and
> general code should probably be applicable for both tools. Most likely
> that any core refactoring/fix in the devlink is needed for rdmatool too.
>
understood and it was not the best model to start with but here we are.
Petr did a good job of refactoring when he added dcb, but rdma was
slightly different so the refactoring did not update it.
next prev parent reply other threads:[~2021-01-10 17:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-03 6:17 [PATCH iproute2-next v2] rdma: Add support for the netlink extack Leon Romanovsky
2021-01-10 17:23 ` David Ahern [this message]
2021-01-11 5:30 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2ad7596-b976-aef7-56b7-edfba3a77ba0@gmail.com \
--to=dsahern@gmail.com \
--cc=dledford@redhat.com \
--cc=jgg@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=phaddad@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).