From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FAAC3C1419; Mon, 4 May 2026 12:12:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777896729; cv=none; b=NM24bzj626N51TeFAPdjdL6hoqG0eBHGHmqMH5lQdxJ++0qgc15nJDGOY/7VK22LShvM5cNg4yjtikTV56zVxpHFzZM72jLA7I+oH0ibWNvBHLXWQfvBwC9qt+KMSOk+0BQXJS87xq6k3AaVlkMe8ueH/znaxau58NaKYRp3AHQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777896729; c=relaxed/simple; bh=2WT+1xuEUaii2BhLVWdlXp1efGYUUNZfjVLiullujCs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Wd0mTyn5oA3HiZPS2cLWQGQwBgBOkjhnkMrIj5FCpxRumNtgsl7qOw62mYCDFR7znB7VmJPhOSv0ptmWvLrhd77B3HhX4QDB2rYI+ZqnShOkBF9IbcrUWsgoeEIDVTMRl/RI8COJI0FAjrI9BWy0BFokFIdkvCEqua7kd248BX4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=tnLX/bCt; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="tnLX/bCt" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=IC6q3csUL/lRdwOp3q5oUmclja9Dv8UZMrCr2gsPnZQ=; b=tnLX/bCtCqEfcPK2EY6LtUJT5Y 0cfNtcI/YKijnzSx6FsvlU/2Q+ZYu2bZmfh5EMUkOP5XgbEsXEa2wBjFz5+dhZ38HH7gfYWiTLiif n+q+JiLLi6XNQCt1oyB8lg2WYzk0YRBYSoGbWGbovU7bKFHVCepUvDuIyCm1fEkSSbkg=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1wJs9F-001FxV-5R; Mon, 04 May 2026 14:11:41 +0200 Date: Mon, 4 May 2026 14:11:41 +0200 From: Andrew Lunn To: "Regus, Ciprian" Cc: Parthiban Veerasooran , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jonathan Corbet , Shuah Khan , Heiner Kallweit , Russell King , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" , "devicetree@vger.kernel.org" Subject: Re: [PATCH net-next 5/5] dt-bindings: net: Add bindings for the ADIN1140 Message-ID: References: <20260503-adin1140-driver-v1-0-dd043cdd88f0@analog.com> <20260503-adin1140-driver-v1-5-dd043cdd88f0@analog.com> <05ae6249-1f40-4530-b2dc-e52e4f454c0d@lunn.ch> <2de08ad6ba73477299b6aace38b6de4b@analog.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2de08ad6ba73477299b6aace38b6de4b@analog.com> > > > + ethernet@0 { > > > + compatible = "adi,adin1140"; > > > + reg = <0>; > > > + spi-max-frequency = <23000000>; > > > + > > > + interrupt-parent = <&gpio>; > > > + interrupts = <6 IRQ_TYPE_EDGE_FALLING>; > > > > Table 1: OPEN serial 10BASE-T1x Interface Pin Definition > > > > IRQn MAC-PHY Interrupt Request (Active Low) > > > > Or is this something else which the device gets wrong? > > The device generates interrupts correctly (the IRQ signal remains > asserted while there are active interrupt conditions that have not > been cleared yet). The oa_tc6 driver requests the interrupt with > the IRQF_TRIGGER_FALLING flag set Ah, that is a bug in oa_tc6.c. A falling edge appears to work, until it does not and then all interrupts stop. So bugs like this are not obvious. I've been looking out for this more over the last few years since PHYs are level, not edge, but many developers get them wrong in DT. Please could you submit a patch to net to fix this? Andrew