Netdev List
 help / color / mirror / Atom feed
From: Su <suyanjun218@gmail.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>,
	manivannan.sadhasivam@linaro.org, thomas.kopp@microchip.com,
	wg@grandegger.com, davem@davemloft.net, kuba@kernel.org,
	lgirdwood@gmail.com, broonie@kernel.org
Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] can: mcp251xfd: Add some sysfs debug interfaces for registers r/w
Date: Fri, 22 Jan 2021 16:04:21 +0800	[thread overview]
Message-ID: <f311f01e-5203-821b-e44f-f0088a4622e7@gmail.com> (raw)
In-Reply-To: <7181a6a3-62c6-9021-ea63-827f55eacd98@pengutronix.de>


在 2021/1/22 下午3:22, Marc Kleine-Budde 写道:
> On 1/22/21 7:22 AM, Su Yanjun wrote:
>> When i debug mcp2518fd, some method to track registers is
>> needed. This easy debug interface will be ok.
> NACK
>
> As the driver uses regmap, everything should be there already.
>
> To read use:
>
> | cat /sys/kernel/debug/regmap/spi0.0-crc/registers
>
> Register write support for devices that are handles by proper kernel drivers is
> a pure debugging tool, thus not enabled by default, not even with a Kconfig
> switch. You have to enable it manually, have a look at commit:
>
> 09c6ecd39410 regmap: Add support for writing to regmap registers via debugfs

You're right.

Thank you

>
> regards,
> Marc
>

  reply	other threads:[~2021-01-22  8:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-22  6:22 [PATCH v1] can: mcp251xfd: Add some sysfs debug interfaces for registers r/w Su Yanjun
2021-01-22  7:22 ` Marc Kleine-Budde
2021-01-22  8:04   ` Su [this message]
2021-01-22  8:51 ` Vincent MAILHOL
2021-01-23 16:36   ` knigh dark

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f311f01e-5203-821b-e44f-f0088a4622e7@gmail.com \
    --to=suyanjun218@gmail.com \
    --cc=broonie@kernel.org \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=mkl@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=thomas.kopp@microchip.com \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox