Re: [PATCH v3 net-next 2/5] psp: add new netlink cmd for dev-assoc and dev-disassoc

[Daniel Zahka <daniel.zahka@gmail.com>]

On 3/9/26 2:34 PM, Wei Wang wrote:
>   +int psp_nl_dev_assoc_doit(struct sk_buff *skb, struct genl_info *info)
> +{
> +	struct psp_dev *psd = info->user_ptr[0];
> +	struct psp_assoc_dev *psp_assoc_dev;
> +	struct net_device *assoc_dev;
> +	u32 assoc_ifindex;
> +	struct sk_buff *rsp;
> +	struct net *net;
> +	int nsid;
> +
> +	if (GENL_REQ_ATTR_CHECK(info, PSP_A_DEV_IFINDEX) ||
> +	    GENL_REQ_ATTR_CHECK(info, PSP_A_DEV_NSID))
> +		return -EINVAL;
> +
> +	nsid = nla_get_s32(info->attrs[PSP_A_DEV_NSID]);
> +	net = get_net_ns_by_id(genl_info_net(info), nsid);
> +	if (!net) {
> +		NL_SET_BAD_ATTR(info->extack, info->attrs[PSP_A_DEV_NSID]);
> +		return -EINVAL;
> +	}

hmm, well I guess I still have the same comment from v2. If assoc_dev is 
in the same netns as genl_info_net(info), then userspace would need to 
create a self-referencing nsid to link them together. It might be a 
better uapi to change PSP_A_DEV_NSID to an optional attribute, and if 
not present then look for PSP_A_DEV_IFINDEX inside of genl_info_net(info).