From: Florian Fainelli <florian.fainelli@broadcom.com>
To: Justin Chen <justin.chen@broadcom.com>, netdev@vger.kernel.org
Cc: pabeni@redhat.com, kuba@kernel.org, edumazet@kernel.org,
davem@davemloft.net, andrew+netdev@lunn.ch,
bcm-kernel-feedback-list@broadcom.com, nb@tipi-net.de,
opendmb@gmail.com
Subject: Re: [PATCH net] net: bcmgenet: if UMAC was suspended in SW_RESET, restore it to SW_RESET
Date: Tue, 29 Sep 2026 13:12:49 -0700 [thread overview]
Message-ID: <f3212307-4ab7-42e1-9b6e-04cf2248c393@broadcom.com> (raw)
In-Reply-To: <20260929192216.1490017-1-justin.chen@broadcom.com>
On 9/29/26 12:22, Justin Chen wrote:
> When the revised suspend/resume sequence was introduced this led to an edge
> case where the TX is left disabled in the following sequence.
>
> 1. phy link is down, so UMAC is held in reset and then network interface
> is WoL enabled
> 2. Enter suspend, bcmgenet_wol_power_down_cfg() enables UMAC_RX since MAC
> is in SW_RESET
> 4. Enter resume, UMAC_RX is left enabled. Since we only enable UMAC_TX
> and UMAC_RX in SW_RESET. The UMAC_TX is never enabled again on link up.
>
> Fixes: 254f3239dd07 ("net: bcmgenet: revise suspend/resume")
> Fixes: 88f6c8bf1aae ("net: bcmgenet: keep MAC in reset until PHY is up")
> Signed-off-by: Justin Chen <justin.chen@broadcom.com>
Excellent catch, thanks!
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
next prev parent reply other threads:[~2026-09-29 20:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 19:22 [PATCH net] net: bcmgenet: if UMAC was suspended in SW_RESET, restore it to SW_RESET Justin Chen
2026-09-29 19:29 ` netdev-bot+sinfo
2026-09-29 20:12 ` Florian Fainelli [this message]
2026-09-29 21:09 ` Nicolai Buchwitz
2026-09-29 22:47 ` Justin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3212307-4ab7-42e1-9b6e-04cf2248c393@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=andrew+netdev@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=justin.chen@broadcom.com \
--cc=kuba@kernel.org \
--cc=nb@tipi-net.de \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox