From: Heiner Kallweit <hkallweit1@gmail.com>
To: "Florian Fainelli" <f.fainelli@gmail.com>,
"Jouni Mettälä" <jtmettala@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [regression] r8169 without realtek_phy
Date: Fri, 17 Aug 2018 20:16:41 +0200 [thread overview]
Message-ID: <f329f7cf-06fd-ad29-6063-172308bde1dc@gmail.com> (raw)
In-Reply-To: <97ad7aae-34f5-a1bc-7131-81eaeea4f4dd@gmail.com>
On 17.08.2018 19:39, Florian Fainelli wrote:
> +Heiner,
>
> On 08/17/2018 01:33 AM, Jouni Mettälä wrote:
>> There is network regression for me. 4.18 was good. 4.18+ is bad. There
>> was some phy changes in r8169 driver. Fortunately adding
>> CONFIG_REALTEK_PHY=m to kernel config fixed the regression.
>>
>> Should r8169 depend on realtek_phy? Does that breaks something else?
>
> That would be reasonable given that there is now a hard dependency on
> the r8169 driver having the right PHY driver, since the Generic PHY
> driver likely wont' do all the workarounds. Heiner, what do you think?
>
Good catch, indeed we need a Kconfig dependency now. I missed this
because I had Realtek PHY support enabled anyway. I will submit a
fix adding this dependency.
Heiner
>
>> Network doesn't work with Generic PHY (output of dmesg)
>> Generic PHY r8169-300:00: attached PHY driver [Generic PHY]
>> (mii_bus:phy_addr=r8169-300:00, irq=IGNORE)
>>
>> When realtek_phy is compiled, r8169 automatically uses it.
>> RTL8211B Gigabit Ethernet r8169-300:00: attached PHY driver [RTL8211B
>> Gigabit Ethernet] (mii_bus:phy_addr=r8169-300:00, irq=IGNORE)
>>
>> Here is Ethernet controller's lspci for reference:
>> 03:00.0 Ethernet controller [0200]: Realtek Semiconductor Co., Ltd.
>> RTL8111/8168/8411 PCI Express Gigabit Ethernet Controller [10ec:8168]
>> (rev 01)
>> Subsystem: ABIT Computer Corp. RTL8111/8168/8411 PCI Express
>> Gigabit Ethernet Controller [147b:1078]
>> Flags: bus master, fast devsel, latency 0, IRQ 27
>> I/O ports at ce00 [size=256]
>> Memory at fddff000 (64-bit, non-prefetchable) [size=4K]
>> [virtual] Expansion ROM at fdd00000 [disabled] [size=64K]
>> Capabilities: [40] Power Management version 2
>> Capabilities: [48] Vital Product Data
>> Capabilities: [50] MSI: Enable+ Count=1/2 Maskable- 64bit+
>> Capabilities: [60] Express Endpoint, MSI 00
>> Capabilities: [84] Vendor Specific Information: Len=4c <?>
>> Capabilities: [100] Advanced Error Reporting
>> Capabilities: [12c] Virtual Channel
>> Capabilities: [148] Device Serial Number 28-00-00-00-00-00-00-
>> 00
>> Capabilities: [154] Power Budgeting <?>
>> Kernel driver in use: r8169
>> Kernel modules: r8169
>>
>
>
prev parent reply other threads:[~2018-08-17 21:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-17 8:33 [regression] r8169 without realtek_phy Jouni Mettälä
2018-08-17 17:39 ` Florian Fainelli
2018-08-17 18:16 ` Heiner Kallweit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f329f7cf-06fd-ad29-6063-172308bde1dc@gmail.com \
--to=hkallweit1@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=jtmettala@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).