From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-187.mta0.migadu.com (out-187.mta0.migadu.com [91.218.175.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B27C140E25 for ; Mon, 8 Apr 2024 15:31:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.187 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712590319; cv=none; b=b2urrOZggmJfyfJXNKfNKLjhmIDAxpL0tptuWELoJ0J5rBpUbGoAduapDrFXg+MN2jwDuyQc2z8AOC45XFflwJp5AP8hhqe+dJu/VCcedkhZ0ACeBXlR20i1u6LNtmJObleiCn92jlLkYXysEFY8WV6Dj9U8ZjnqoALkBBPuti0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712590319; c=relaxed/simple; bh=tjGt1QyN3u9SP4WWPTA1ilz084j0cSgzKV09txr9r/E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=a5psR9lABHXrq5RfdJ/HTLSwlK17i4ozE5I6QHal+W4DuCvWiPfemtDWHjuM4+6NqQ+Ee2u/Lm5mOL9MOY1/wftQTQO5aRCPwvgcDse59LT3E7tOXpk91XWGBjGr02OfZKH7AMlR1k7iWHDRpztwYu+GVvcvCCWlJXjQD/t6PxY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=BHu/3H5K; arc=none smtp.client-ip=91.218.175.187 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="BHu/3H5K" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1712590315; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tjGt1QyN3u9SP4WWPTA1ilz084j0cSgzKV09txr9r/E=; b=BHu/3H5KbrEWe1u/+wFTHRkWp+IaZV2pwuHoPyv9t2T0sDstk+EvDR6obNnJ/Unt+NbC0c 1hgtbWozusE5JqIJLMqp4At8ymZz5OHnEWsY2g+y2KwbpIYgho1JQ848X/h/IbTnIvZcpK OLof+IZ5d0N2igNyMsufTWRFhWAB/pA= Date: Mon, 8 Apr 2024 08:31:44 -0700 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH net-next] selftests/bpf: eliminate warning of get_cgroup_id_from_path() Content-Language: en-GB To: Jason Xing , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com, haoluo@google.com, jolsa@kernel.org, mykolal@fb.com, shuah@kernel.org Cc: bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, netdev@vger.kernel.org, Jason Xing References: <20240406144613.4434-1-kerneljasonxing@gmail.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yonghong Song In-Reply-To: <20240406144613.4434-1-kerneljasonxing@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT On 4/6/24 7:46 AM, Jason Xing wrote: > From: Jason Xing > > The output goes like this if I make samples/bpf: > ...warning: no previous prototype for ‘get_cgroup_id_from_path’... The CI does not build samples/bpf... > > Make this function static could solve the warning problem since > no one outside of the file calls it. > > Signed-off-by: Jason Xing But your change looks fine. Acked-by: Yonghong Song