From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm2-f13.google.com (mail-wm2-f13.google.com [74.125.225.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62500348C5D for ; Fri, 18 Sep 2026 21:50:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789768247; cv=none; b=uDOAepElhYpuWnRBbXI8Fgobb+V4pV7AnQLdBll6hk1n3ZYBPmLLhWT1/Rh1zSBsnhFBXzlLjO0v/5PSOk/BeHUa2eQ0/GYxC/kcyHHsXxR9s6qxnLVUitIwPkV3g26ae8phdnzxgfg/n4p0J2pojVq9SG5RuTJQWxY/TFfRApc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789768247; c=relaxed/simple; bh=8lFK5oAIN3UPCIPodD7oNRYoewM6xA0f85WZD5FvR4o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ixNOiZH9lzLdimSUDtFLwbeRZ/0zWJbJIbshqdZSZOXTVYwQRqzmdsQnM1kpeFKetjRXXLuRCpQl0Tw0KUQeVoeNGkyE4hw8xrz8cqJNOtByFthZsZDGOE/Me3QYO0NGIYXz8ouNnMHqUGvInaSELCu+344SXXMLLv2Ly3t9Kh8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JznJLopL; arc=none smtp.client-ip=74.125.225.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JznJLopL" Received: by mail-wm2-f13.google.com with SMTP id 5b1f17b1804b1-49e7c6dbc60so884485e9.3 for ; Fri, 18 Sep 2026 14:50:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789768245; x=1790373045; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=hRu9WFQ43wFkJswy5poP93mM4ID1VlyzM9+cjmFxTAM=; b=JznJLopLmD1v/ZNdN8N+DlCoAhGbI5VlSDgtdYbUSi/ed3pUnb60RXKH+wbzTKBSp9 Dh4Y/bYQWa9s20a/p8R1j6ungz14eTurX+GKkzIOQ2VKgcwNCfAijgaZs/dANfhycJs9 0rvc95ZHQ9mZXfoQmVV9ONx9VaQMphxym0kCg4Ef4qYZP7GCMu0qK/Tu0nzy8wlnYHn9 Mj+1xFJ4+kdFCd1YWcA34X5VspQ8A7j+PlpVtwwgk0kNeZt0nRF3Ix1ERmORTLRDc30k deM8UNHB8R+U+5kIhjqP1lhS5CfwK5AO9OH3fCThNdLBkHfYvnQEoCNjVn+TMZYifKMJ +IOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789768245; x=1790373045; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=hRu9WFQ43wFkJswy5poP93mM4ID1VlyzM9+cjmFxTAM=; b=zGrPFK9PRWJXjReTYKZ9s5KNt9te9r94HFbesq0iVvdTrKTlNKY5rLRv/n5b67F/mv m1IkKMZKiP94RfoMWwhAgk1j6LdgeX1DdADctrqdIEwzrjW8IvYyTTmaDJWUX9EHyLc/ ajwK0x4spifMmO3j5x+f/v24woujUMjgSINcciMU+F6GR+cMMofV8B/hYnsh+wmNu9ne iz9wl5q5g7ks8MofwnVdBtO5b0Zy1cPtnpY/8wWvtjRVw5mCCkcWKy87xLQDuCiiNEKn NE8VClLnCpDhZQa1MiP0h/Iajr5d30W8qh3DKTowthotj2X+vsSadfT7VAN+TESFUT8T CLEw== X-Forwarded-Encrypted: i=1; AKwUvByvgGN+asqHnzq3n662GkF9HMOhBiXPejDy8Hi2l0CG0fitLmsSrAvWJBSt18qGz+jG/YGx2pc=@vger.kernel.org X-Gm-Message-State: AFuF++nMOL0GVBB402fxUBvhiBFA86xVdiDvfx8OL9bNY30/LFWMn20Z JMXNx+DBuME9/Nly7C6O7NYEfZUj9Ruz7HxB/afZpYjjW+b/+yx7zl7e X-Gm-Gg: AYBFou0HwN3dqBbHqOjyX/Rpj4zmTuiIgjzcLySJ953H7raWkNgG4covyBXksUdwDHq XsHSoweVZb4XUchWQ4+NXgZ1ldmXPeBI7ndHORuXt2a3wH+iOApbyLrI24sJAZoosyWrvf5Yof5 5oEyndkrGu/sxR2Hpx4zz1XLM4mlS5Rm8pXi/QXyAnxzO/dMyFYZTFrBJQy0TqSnFezE4YKEgjq J/yCdNGwm6CcwDnnVbv3MeEk3CBxMTv3qj2GJJedelXGvnJCLreT1fdaERwTS8eyRqAT26plHEl ezhMlLqDiJh/FdySxIoJmqgNaWTtaNDGI5OMevM4pKFed13kesX4mo6c0b+6iJbLKwTnP+yAvnn pd58LTHvXlD6FiXOfXy/o345Kvk5Egn6VjraxkN0dsSq6CpqV76QmBqKtyq5dvEeHfd67dGEDQS ParYLR773HY6jGI59FAWHD8tew2OJqz7+1/RsXHWuaYCZd+uw2AsihMIVekIs20zVrUph9i2aPZ dsZ4PGkf14Ak5rp1QR6dniFFbL+uIfzJthArCL5nCOFjJpZpn2YPVou/pR5+GDa0QlQ49PFY/KG XLpKbCGf5QzTfDjrkeeSazq37nwVDMzlUiJMCoxK4U1wMJpBewq9dLrPVEvlykuRo3Cco/r53nA 7CtWN4NeWVgwaiw1vRg== X-Received: by 2002:a05:600c:35c2:b0:49d:1da4:511b with SMTP id 5b1f17b1804b1-49fc7dd94c0mr46884445e9.1.1789768244519; Fri, 18 Sep 2026 14:50:44 -0700 (PDT) Received: from ?IPV6:2a02:3100:59ae:19fc:400:b6b0:efdd:810c? (dynamic-2a02-3100-59ae-19fc-0400-b6b0-efdd-810c.310.pool.telefonica.de. [2a02:3100:59ae:19fc:400:b6b0:efdd:810c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fcd1149e0sm20470715e9.13.2026.09.18.14.50.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Sep 2026 14:50:43 -0700 (PDT) Message-ID: Date: Fri, 18 Sep 2026 23:50:42 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v3 2/3] net: hsr: return private clones from the tagged-frame helpers To: Jakub Kicinski Cc: davem@davemloft.net, pabeni@redhat.com, edumazet@google.com, horms@kernel.org, shuah@kernel.org, lukma@denx.de, m-karicheri2@ti.com, fmaurer@redhat.com, luka.gejak@linux.dev, bigeasy@linutronix.de, ali@iusegentoo.com, qingfang.deng@linux.dev, netdev@vger.kernel.org, linux-kselftest@vger.kernel.org References: <20260808004525.1551-3-xiexinet@gmail.com> <20260814012738.2806035-1-kuba@kernel.org> Content-Language: en-GB From: Xin Xie Autocrypt: addr=xiexinet@gmail.com; keydata= xsDNBGpiHugBDADJ5KuJaOYfUx7TGbRw0UE1km4dLnJomCSNtgq2T9BqgZ6TRPEy37soAmW3 XxCPvhfL6CPLldzy6O6EkUD7/8zlbQP1DM6gUIQUyKxxkb8uR+oCogDKjsxt0QPycP/dR9fk SL4qKReprnkOOcGeLahLHzofVdn46mc5igCBsAA/PPSpo1GqsfGk+zYV97rSVa8zhnSXsqZ/ 9DbUfQynZKVqYN4tm1B30JE5SEWDCko95Qw9fAORX2W356MOQJGr05z9qMSy7CkF7bAUkziG d6ZSPsGEsel5jYByP8ZvwQ2A8kdKpRy8+zQCaC+vEotTH7Fs7SIzE/Z5mEVIi1xQqEzN1rqG BW7KgzRDWjw8lKsoBbxv20nfhUzuZLan2HzUJ+LxZ18Os4zkWg9sxHgMi+AGqn/+0ppbDcOH 9Jm072/xA7O1MCXLgr4FOP+4PJH1vcqU+0EZVz7KCjrwkdz+l5Ojso2FLXq2MGoqWGShIsDV bF1JYpgm4spdPbnISkidUC0AEQEAAc0cWGluIFhpZSA8eGlleGluZXRAZ21haWwuY29tPsLB DQQTAQgANxYhBAHOahKZFnMu2n/CxrTrSufyPi3LBQJqYh7oBQkFo5qAAhsDBAsJCAcFFQgJ CgsFFgIDAQAACgkQtOtK5/I+LctmngwAlmrGPWnWxDW6PSJeR9SM0faqwuY33TWAE35nshm/ EEkBgpVVhG4z4Cdy7L+6TG6NHVDnvl+IHLyyOZlL3LQPQIpiKVgo6jHmm9TF6mK+Vo3nsXAA uSJYu9iY9Aywmy2JVQ15ttQ0NfcoZ0sV14bT7pSr9zXB6D8p3XA4AQI6IBeLvj993Z1+tPyC 6BJ+2aWWLBx7xGpFo3X8dhjS/Lm8QoietKbI+ACefKKCDNiM2KG53P76wdXJp52u4dqP6eFc +Qv35QefnALoPkOGQEdd1qvUycyZhuaCj8h0AxDu7bL3G/IM8G2K8qsbSJuui8zCSZ9b/QZf H7u1nevPOgxyWC1Pep/TbRZ62ktn8lrmWA8PZjuaJJQGjahuK1GgTQZNG+7DB7NwjLr6aXIm JirtT4FeR+IUovvL/ll+VHzpGpFbgXz4GTsWsikQkT1huFSB8MRLlWMXdAKblL96L754j8Z5 p/YV26YTppXI56uJ3XyOwZSrfrK1pfqNIp2Yr9vUzsDNBGpiHukBDACePM1YZ1FvAiFay/2v KVDNpuazmpVb1CBFy+rqM9HcuHe+5CuxLd4RI4hb0qmjlm5Vi5M8+AuNB/wi/f8oDuhJwlMn v9L0lfgpRRdShnB26hnt2wWwWFgOU3BwymSruxhEYq+eIjjxCAo6yW7Qm+ArZ+riETMI67sy ZyLx6o4yRiWxOrh1nhwV/f6PIOl+Iv4yLAG3eFXpU7/EZpim610bKMwcXEpiRkf3NjiflIha adoKHV0LCiVNrU7r8TICjjnugpl1tXAR2RlaRcSxmvOzrXY2O/xBLpwPr5erbdk8RCaxUzS0 kK0hw+/On3Sr4Z4gtLl2xtDkjRh3KQ9ZqMPrFD/5XOs842ueNivwIyAf2kQJjKfJGWc771EM 0ZWo1r1AthbuM+IeN5QM74rMJxaf5WyDX3ZeqBA55fCJGJ3zrp7Tqeoq8DYufiNkppE9S71z Cvxva2f8mUWTlTUf8s33sRD7C87XpT0whKpn1I9/nJB9Kb0dKyRCdcsT4o1ynxUAEQEAAcLA /AQYAQgAJhYhBAHOahKZFnMu2n/CxrTrSufyPi3LBQJqYh7pBQkFo5qAAhsMAAoJELTrSufy Pi3L/iwL/3aoCeq19Pog3fqisRyEZeX8pXw2GYlrJWYoM0mQ1USaTpdsMwCXaoFMoSBqid0F VPrqlH4bSIEEAzVmFPX0NjGhREDMrQ9eR5S9yqSpBvX+hz+xgpt4NOPhbVQmV+9f4lX9TJT7 GOO3EX2eeokg6ZAISycCAx7srXuc8oyRTJtnUQziH9GXrEeon88LHf1QHg0Z0sL/c7DfDqvW 9924M4ngQAZ8RgCBGZocoWuXCemSPkfQVLt5DzycSgSQODhbNSEmr+jb1V9Svf9D9k0CQfEY cB3uwOHWb6Z/yaEARbGZPSPn89YjXBncQTpgSvUM578b5x3pKi6PjZB/hwtUsRgrWGWoIwRi +ZmcHnCzsuo6uuNYX8VvmWqYsVajykjnpjdCGmU89QUsVmrtnDPBrfr8VVJcZPnCJhE595Pk LO29Oj0au9kr7kMW5Q+fBeHj5zz6VggAaRRU74/sgtwLODBWESPZ9LqUUdB5L/XbrSq2VDlD sNySbH3veZ/55EtlXA== In-Reply-To: <20260814012738.2806035-1-kuba@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 14/08/2026 03:27, Jakub Kicinski wrote: > [Severity: High] > This isn't a bug introduced by this patch, but should the sibling > get_untagged_frame() callbacks be privatized the same way? > ... > One more consumer of the same bytes: an AF_PACKET listener on the slave > device gets its clone in packet_rcv() before hsr_handle_frame() runs, so > does it also observe the rewritten h_source? Yes. Master delivery can rewrite frame->skb_std through its clone before the later slave copies it. When the learned A and B addresses differ, that copy preserves the substituted address rather than the original source. An earlier packet-socket clone can also be affected. I'll compare private untagged returns with COW at the writers before settling the v4 ownership changes. -- Xin