RE: [PATCH v8 net-next 5/5] net: ena: Add PHC documentation

["Arinzon, David" <darinzon@amazon.com>]

> >> > I think the sysfs control is the best option here.
> >>
> >> Actually, it occurs to me that the best option is probably a module
> >> parameter. If you have to take the network down and up to change the
> >> mode, why not just unload and reload the module?
> >
> > We have something called devlink params, which support "configuration
> > modes" (= what level of reset is required to activate the new setting).
> > Maybe devlink param with cmode of "driver init" would be the best fit?
> 
> I had same feeling when I wrote my auxbus response. There is no reason to
> believe that ptp enable/disable knob won't be usable by other drivers
> 
> It's universally usable, just not related to netdev sysfs layout.
> 
> Thanks
> 
> >
> > Module params are annoying because they are scoped to code / module
> > not instances of the device.

Hi Jakub,

Thanks for suggesting the devlink params option for enable/disable, we will
explore the option and provide a revised patchset.

Given the pushback on custom sysfs utilization, what can be the alternative for exposing 
the PHC statistics? If `ethtool -S` is not an option, is there another framework that
allows outputting statistics?
We've explored devlink health reporter dump, would that be acceptable?

Thanks,
David