From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5336EC433E0 for ; Tue, 12 Jan 2021 21:40:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1990823123 for ; Tue, 12 Jan 2021 21:40:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393185AbhALVkT (ORCPT ); Tue, 12 Jan 2021 16:40:19 -0500 Received: from mga01.intel.com ([192.55.52.88]:47666 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392968AbhALVkI (ORCPT ); Tue, 12 Jan 2021 16:40:08 -0500 IronPort-SDR: xYKS00vz0lhDZYoJwTMPFwY6G7vV1VNfu3S3E7FSENhrRvgFqzDl3NENftlNvUgZBDX/lBDu1J 0RUErvd/eJoA== X-IronPort-AV: E=McAfee;i="6000,8403,9862"; a="196740362" X-IronPort-AV: E=Sophos;i="5.79,342,1602572400"; d="scan'208";a="196740362" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2021 13:38:19 -0800 IronPort-SDR: 2SQCWOzeUZ2/0GfO/qAorddSiUjA6Pb1QsQ/YuGjuNVFz9Q7UhSDsdGXptfWQfnmUeSjBWwkuM 4lsEwvsE2cxg== X-IronPort-AV: E=Sophos;i="5.79,342,1602572400"; d="scan'208";a="352009948" Received: from smakanda-mobl1.gar.corp.intel.com ([10.254.115.163]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2021 13:38:19 -0800 Date: Tue, 12 Jan 2021 13:38:18 -0800 (PST) From: Mat Martineau To: Paolo Abeni cc: netdev@vger.kernel.org, mptcp@lists.01.org, "David S. Miller" , Jakub Kicinski Subject: Re: [MPTCP] [PATCH net 2/2] mptcp: better msk-level shutdown. In-Reply-To: <4cd18371d7caa6ee4a4e7ef988b50b45e362e177.1610471474.git.pabeni@redhat.com> Message-ID: References: <4cd18371d7caa6ee4a4e7ef988b50b45e362e177.1610471474.git.pabeni@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 12 Jan 2021, Paolo Abeni wrote: > Instead of re-implementing most of inet_shutdown, re-use > such helper, and implement the MPTCP-specific bits at the > 'proto' level. > > The msk-level disconnect() can now be invoked, lets provide a > suitable implementation. > > As a side effect, this fixes bad state management for listener > sockets. The latter could lead to division by 0 oops since > commit ea4ca586b16f ("mptcp: refine MPTCP-level ack scheduling"). > > Fixes: 43b54c6ee382 ("mptcp: Use full MPTCP-level disconnect state machine") > Fixes: ea4ca586b16f ("mptcp: refine MPTCP-level ack scheduling") > Signed-off-by: Paolo Abeni > --- > net/mptcp/protocol.c | 62 ++++++++++++-------------------------------- > 1 file changed, 17 insertions(+), 45 deletions(-) > Reviewed-by: Mat Martineau -- Mat Martineau Intel