From: David Ahern <dsahern@gmail.com>
To: David Miller <davem@davemloft.net>, ssuryaextr@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net,v2] vrf: check accept_source_route on the original netdevice
Date: Sun, 31 Mar 2019 18:06:23 -0600 [thread overview]
Message-ID: <f3ae7363-f1a1-b290-8797-7aff6d514d65@gmail.com> (raw)
In-Reply-To: <20190331.135759.2294308002162343207.davem@davemloft.net>
On 3/31/19 2:57 PM, David Miller wrote:
> From: Stephen Suryaputra <ssuryaextr@gmail.com>
> Date: Wed, 27 Mar 2019 15:58:48 -0400
>
>> Configuration check to accept source route IP options should be made on
>> the incoming netdevice when the skb->dev is an l3mdev master. The route
>> lookup for the source route next hop also needs the incoming netdev.
>>
>> Signed-off-by: Stephen Suryaputra <ssuryaextr@gmail.com>
>
> David, please review this.
>
> Thanks.
>
now that my heart rate is back to normal following the Auburn game ...
The change can be much simpler by passing the device down the stack from
where it is saved before the skb->dev switch.
next prev parent reply other threads:[~2019-04-01 0:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 19:58 [PATCH net,v2] vrf: check accept_source_route on the original netdevice Stephen Suryaputra
2019-03-29 18:12 ` David Miller
2019-03-31 20:57 ` David Miller
2019-04-01 0:06 ` David Ahern [this message]
2019-04-01 0:04 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3ae7363-f1a1-b290-8797-7aff6d514d65@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ssuryaextr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).