From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27964C43381 for ; Mon, 1 Apr 2019 00:06:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E1E3620872 for ; Mon, 1 Apr 2019 00:06:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="uwZ9s3Y/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731593AbfDAAG0 (ORCPT ); Sun, 31 Mar 2019 20:06:26 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:44845 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731335AbfDAAG0 (ORCPT ); Sun, 31 Mar 2019 20:06:26 -0400 Received: by mail-pg1-f194.google.com with SMTP id i2so3792635pgj.11 for ; Sun, 31 Mar 2019 17:06:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=cxSZ1TyhiA1Z3WcoB7mGyMzowcAv8NywS990N6jtRF4=; b=uwZ9s3Y/T/ZeCDRhkMoh92dqzsyC4JMPeAGu0kbeTj/q6J3mIXZ4YaOzihb0/37e+J aWglpoeg/fNpxMuq6g3PvHkBU/UpgfITiA7R3o5DFfQrTWf+RPBjGC9oMFcFgCd0DOBN dlOO5mD1s8UEtOxyQMyRcZcuxKZcfwtJBJxX70jWra6kCizDO3/GWm+xd7gqBDASXK// SuMOQ0hiD/IASZz+lG2Iv2y+qFE/KPxdpMgepLkTA/8N62xO2rYJk/uRIrz3xpQf6/WU KYHl4GjpUvL30dFQo8Zt1lrPW/f/iWjrVVTP16Y9YJRdiVma3Tgx6TGHk9S1qLpp+XoQ UAuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=cxSZ1TyhiA1Z3WcoB7mGyMzowcAv8NywS990N6jtRF4=; b=TOVsKzf4K4po6C3XRQCSyZ8S/J1GaaaILCnd7c6Hqv1HimZvDLnF3vm6jVUjzs206Q lR7D/JaxW8wfanR19INSijaEh3L8FUVa174SPCVQFiFVP/pcAZeUsVTeNkvOn41yHli8 3twRYXXDJk2v4TfSopw2qDshhBxoL5/tFEYKfkVtc2SjbMX2w+2qFA+dF2f55ej30TPh lfSHsHeMx0KmqBANLO9OCvyzIpuwndyZ6k9qFn10scBfTg2SYFbwVMg35w2F7ZCHB5xl rh0jdnRGIatzlhLlpsPMt+7ktDUDzNgSSFxoKjJkCYqcpR+WnpK6Hn+lyEUf5/xwHpU2 ELUQ== X-Gm-Message-State: APjAAAWelaRzxOzJGTENeOibqDFFi1/t5Zp5k33iDrs0GcQBc8oEXY1s 3U9nHu63jK6QBTO7isL2BWvD3d+Q X-Google-Smtp-Source: APXvYqxMmkFflSCd7xlyQBDnoYqoBBayyLneQSYTb5D2hLZ4nIbImMqekn+LJXfFgS7Pb1vU3yvuEw== X-Received: by 2002:a62:3892:: with SMTP id f140mr53725699pfa.128.1554077185360; Sun, 31 Mar 2019 17:06:25 -0700 (PDT) Received: from ?IPv6:2601:282:800:fd80:a8fa:80d6:e7f9:2780? ([2601:282:800:fd80:a8fa:80d6:e7f9:2780]) by smtp.googlemail.com with ESMTPSA id b3sm11256270pfi.82.2019.03.31.17.06.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 31 Mar 2019 17:06:24 -0700 (PDT) Subject: Re: [PATCH net,v2] vrf: check accept_source_route on the original netdevice To: David Miller , ssuryaextr@gmail.com Cc: netdev@vger.kernel.org References: <20190327195848.7080-1-ssuryaextr@gmail.com> <20190331.135759.2294308002162343207.davem@davemloft.net> From: David Ahern Message-ID: Date: Sun, 31 Mar 2019 18:06:23 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190331.135759.2294308002162343207.davem@davemloft.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 3/31/19 2:57 PM, David Miller wrote: > From: Stephen Suryaputra > Date: Wed, 27 Mar 2019 15:58:48 -0400 > >> Configuration check to accept source route IP options should be made on >> the incoming netdevice when the skb->dev is an l3mdev master. The route >> lookup for the source route next hop also needs the incoming netdev. >> >> Signed-off-by: Stephen Suryaputra > > David, please review this. > > Thanks. > now that my heart rate is back to normal following the Auburn game ... The change can be much simpler by passing the device down the stack from where it is saved before the skb->dev switch.