From: Florian Fainelli <f.fainelli@gmail.com>
To: Tobias Waldekranz <tobias@waldekranz.com>, davem@davemloft.net
Cc: netdev@vger.kernel.org, andrew@lunn.ch, hkallweit1@gmail.com,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v3 2/2] net: phy: add marvell usb to mdio controller
Date: Sun, 22 Mar 2020 14:10:31 -0700 [thread overview]
Message-ID: <f3b8f07f-b09b-50ed-b642-3224e243b91e@gmail.com> (raw)
In-Reply-To: <20200321202443.15352-2-tobias@waldekranz.com>
Hi Tobias,
On 3/21/2020 1:24 PM, Tobias Waldekranz wrote:
> An MDIO controller present on development boards for Marvell switches
> from the Link Street (88E6xxx) family.
>
> Using this module, you can use the following setup as a development
> platform for switchdev and DSA related work.
>
> .-------. .-----------------.
> | USB----USB |
> | SoC | | 88E6390X-DB ETH1-10
> | ETH----ETH0 |
> '-------' '-----------------'
>
> Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com>
> ---
[snip]
> +config MDIO_MVUSB
> + tristate "Marvell USB to MDIO Adapter"
> + depends on OF_MDIO && USB
You could drop OF_MDIO here since of_mdiobus_register() does default to
mdiobus_register() when CONFIG_OF is disabled. Other than that, LGTM!
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2020-03-22 21:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-21 20:24 [PATCH v3 1/2] dt-bindings: net: add marvell usb to mdio bindings Tobias Waldekranz
2020-03-21 20:24 ` [PATCH v3 2/2] net: phy: add marvell usb to mdio controller Tobias Waldekranz
2020-03-22 7:40 ` Greg KH
2020-03-22 9:09 ` Tobias Waldekranz
2020-03-22 11:10 ` Greg KH
2020-03-22 13:32 ` Andrew Lunn
2020-03-22 21:10 ` Florian Fainelli [this message]
2020-03-22 13:33 ` [PATCH v3 1/2] dt-bindings: net: add marvell usb to mdio bindings Andrew Lunn
2020-03-22 13:35 ` Andrew Lunn
2020-03-22 14:38 ` Tobias Waldekranz
2020-03-22 21:03 ` Florian Fainelli
2020-03-30 15:11 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3b8f07f-b09b-50ed-b642-3224e243b91e@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tobias@waldekranz.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).