From: Nicolai Buchwitz <nb@tipi-net.de>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: netdev@vger.kernel.org, Phil Elwell <phil@raspberrypi.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] net: phy: microchip: add downshift tunable support for LAN88xx
Date: Tue, 31 Mar 2026 13:40:57 +0200 [thread overview]
Message-ID: <f3c1a8af592115ca9a77b3249fa167bf@tipi-net.de> (raw)
In-Reply-To: <acuwKGBn6UKfRCjU@shell.armlinux.org.uk>
On 31.3.2026 13:29, Russell King (Oracle) wrote:
> On Tue, Mar 31, 2026 at 12:46:26AM +0200, Nicolai Buchwitz wrote:
>> Implement the standard ETHTOOL_PHY_DOWNSHIFT tunable for the LAN88xx
>> PHY. This allows runtime configuration of the auto-downshift feature
>> via ethtool:
>>
>> ethtool --set-phy-tunable eth0 downshift on count 3
>>
>> The LAN88xx PHY supports downshifting from 1000BASE-T to 100BASE-TX
>> after 2-5 failed auto-negotiation attempts. Valid count values are
>> 2, 3, 4 and 5.
>>
>> This is based on an earlier downstream implementation by Phil Elwell.
>>
>> Signed-off-by: Nicolai Buchwitz <nb@tipi-net.de>
>
> I didn't see a cover message. Please always include a cover message
> with
> patch series.
Apparently the cover message [1] was sent with slightly different
recipients (although it was a single git send-email with
--cc-cmd='scripts/get_maintainer.pl --norolestats').
> Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Thanks, I will add it to the patch.
Nicolai
> Thanks!
[1]
https://lore.kernel.org/netdev/20260330224630.579937-1-nb@tipi-net.de/
next prev parent reply other threads:[~2026-03-31 11:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 22:46 [PATCH net-next v2 0/2] net: phy: microchip: add downshift support for LAN88xx Nicolai Buchwitz
2026-03-30 22:46 ` [PATCH v2 1/2] net: phy: microchip: add downshift tunable " Nicolai Buchwitz
2026-03-31 1:02 ` Andrew Lunn
2026-03-31 11:29 ` Russell King (Oracle)
2026-03-31 11:40 ` Nicolai Buchwitz [this message]
2026-03-30 22:46 ` [PATCH v2 2/2] net: phy: microchip: enable downshift by default on LAN88xx Nicolai Buchwitz
2026-03-31 11:32 ` Russell King (Oracle)
2026-03-31 11:58 ` Nicolai Buchwitz
2026-03-31 12:01 ` Russell King (Oracle)
2026-03-31 12:41 ` Nicolai Buchwitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3c1a8af592115ca9a77b3249fa167bf@tipi-net.de \
--to=nb@tipi-net.de \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=phil@raspberrypi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox