Re: [PATCH net-next 1/3] net: mctp: perform source address lookups when we populate our dst

[Jeremy Kerr <jk@codeconstruct.com.au>]

Hi Pablo,

> > Rather than querying the output device for its address in
> > mctp_local_output, set up the source address when we're populating the
> > dst structure. If no address is assigned, use MCTP_ADDR_NULL.
> > 
> > This will allow us more flexibility when routing for NULL-source-eid
> > cases. For now though, we still reject a NULL source address in the
> > output path.
> > 
> > We need to update the tests a little, so that addresses are assigned
> > before we do the dst lookups.
> > 
> > Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
> 
> Sashiko pointed to a possible pre-existent issue:
> 
> https://sashiko.dev/#/patchset/20260331-dev-mctp-null-eids-v1-0-b4d047372eaf%40codeconstruct.com.au
> 
> please have a look and follow-up if needed.

Yes, I've just been checking that out this afternoon. While there's
nothing pressing there (the findings are somewhat valid, but don't
affect any typical behaviour), I think it's worth a fix.

Given the merge to net-next, I assume a patch on top of the series is in
order, but let me know if you'd like something else.

Cheers,


Jeremy