From: Jens Axboe <axboe@kernel.dk>
To: KobaK <kobak@nvidia.com>, Pavel Begunkov <asml.silence@gmail.com>
Cc: Keith Busch <kbusch@kernel.org>, Ming Lei <ming.lei@redhat.com>,
io-uring@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] io_uring: fix resource leak issues
Date: Wed, 8 Apr 2026 06:51:46 -0600 [thread overview]
Message-ID: <f3dc1661-02d1-4bbf-bf3e-c3d7d323b818@kernel.dk> (raw)
In-Reply-To: <20260408065408.2017967-1-kobak@nvidia.com>
On 4/8/26 12:54 AM, KobaK wrote:
> From: Koba Ko <kobak@nvidia.com>
>
> Three resource leak fixes found by code audit:
>
> 1. memmap: pinned pages and pages array leak on WARN_ON path in
> io_region_pin_pages() ? mr->pages is never assigned so the caller's
> cleanup is a no-op.
>
> 2. rsrc: kfree() used instead of io_cache_free() in
> io_buffer_register_bvec() error path ? bypasses cache return.
>
> 3. zcrx: io_import_umem() leaves live pinned pages in a partially
> initialized struct on io_account_mem() failure, and
> io_release_area_mem() is not idempotent (missing pages = NULL),
> creating a double-free hazard.
General advice - anyone can point an LLM at a code base and get some
reports, but please apply some actual critical thinking to the "issues"
found before blindly sending them out.
--
Jens Axboe
prev parent reply other threads:[~2026-04-08 12:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 6:54 [PATCH 0/3] io_uring: fix resource leak issues KobaK
2026-04-08 6:54 ` [PATCH 1/3] io_uring: fix pinned pages and pages array leak in io_region_pin_pages() KobaK
2026-04-08 8:34 ` Pavel Begunkov
2026-04-08 6:54 ` [PATCH 2/3] io_uring/rsrc: use io_cache_free for node in io_buffer_register_bvec error path KobaK
2026-04-08 8:35 ` Pavel Begunkov
2026-04-08 12:49 ` Jens Axboe
2026-04-08 6:54 ` [PATCH 3/3] io_uring/zcrx: fix resource leak and double-free hazard in io_import_umem KobaK
2026-04-08 9:06 ` Pavel Begunkov
2026-04-08 12:51 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3dc1661-02d1-4bbf-bf3e-c3d7d323b818@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=io-uring@vger.kernel.org \
--cc=kbusch@kernel.org \
--cc=kobak@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox