From: Santosh Shilimkar <santosh.shilimkar@oracle.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Colin King <colin.king@canonical.com>
Cc: "David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
rds-devel@oss.oracle.com, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RDS: IB: ensure an initialized ret is printed in pr_warn message
Date: Fri, 7 Apr 2017 08:59:46 -0700 [thread overview]
Message-ID: <f3de73cb-f56a-9e6e-a39b-7cee16030b22@oracle.com> (raw)
In-Reply-To: <20170407142412.GA4471@mwanda>
On 4/7/2017 7:24 AM, Dan Carpenter wrote:
> Setting it to zero doesn't seem like the right thing, it should be an
> error code. Oh, heh... Smatch parses this one correctly. "ret" is
> always initialized but the code is probably buggy in a different way:
>
[...]
> 561 ibmr = rds_ib_reg_fmr(rds_ibdev, sg, nents, key_ret);
> 562 if (ibmr)
> ^^^^
> This condition is always true because those functions return ERR_PTRs
> not NULLs.
>
Thanks Dan. I will fix that up.
Regards,
Santosh
prev parent reply other threads:[~2017-04-07 15:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 7:57 [PATCH] RDS: IB: ensure an initialized ret is printed in pr_warn message Colin King
2017-04-07 13:10 ` David Miller
2017-04-07 14:24 ` Dan Carpenter
2017-04-07 15:59 ` Santosh Shilimkar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3de73cb-f56a-9e6e-a39b-7cee16030b22@oracle.com \
--to=santosh.shilimkar@oracle.com \
--cc=colin.king@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).