From: David Ahern <dsahern@gmail.com>
To: David Ahern <dsahern@kernel.org>, netdev@vger.kernel.org
Cc: stephen@networkplumber.org
Subject: Re: [PATCH iproute2-next] libnetlink: Use NLMSG_LENGTH to set nlmsg_len
Date: Fri, 5 Oct 2018 14:09:17 -0600 [thread overview]
Message-ID: <f3e6c7f9-912c-1b3b-0268-f5447af8946d@gmail.com> (raw)
In-Reply-To: <20181004213737.27846-1-dsahern@kernel.org>
On 10/4/18 3:37 PM, David Ahern wrote:
> From: David Ahern <dsahern@gmail.com>
>
> Some of the inner headers are not 4-byte aligned, so use
> NLMSG_LENGTH instead of sizeof(req) to set nlmsg_len.
>
this patch is wrong; headers are supposed to be 4-bytes aligned.
prev parent reply other threads:[~2018-10-06 3:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 21:37 [PATCH iproute2-next] libnetlink: Use NLMSG_LENGTH to set nlmsg_len David Ahern
2018-10-05 20:09 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3e6c7f9-912c-1b3b-0268-f5447af8946d@gmail.com \
--to=dsahern@gmail.com \
--cc=dsahern@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).