From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH iproute2-next] libnetlink: Use NLMSG_LENGTH to set nlmsg_len Date: Fri, 5 Oct 2018 14:09:17 -0600 Message-ID: References: <20181004213737.27846-1-dsahern@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: stephen@networkplumber.org To: David Ahern , netdev@vger.kernel.org Return-path: Received: from mail-pg1-f193.google.com ([209.85.215.193]:41802 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728160AbeJFDJg (ORCPT ); Fri, 5 Oct 2018 23:09:36 -0400 Received: by mail-pg1-f193.google.com with SMTP id 23-v6so5177334pgc.8 for ; Fri, 05 Oct 2018 13:09:19 -0700 (PDT) In-Reply-To: <20181004213737.27846-1-dsahern@kernel.org> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 10/4/18 3:37 PM, David Ahern wrote: > From: David Ahern > > Some of the inner headers are not 4-byte aligned, so use > NLMSG_LENGTH instead of sizeof(req) to set nlmsg_len. > this patch is wrong; headers are supposed to be 4-bytes aligned.