From: Alexandra Winter <wintera@linux.ibm.com>
To: Wen Gu <guwen@linux.alibaba.com>,
wenjia@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com,
agordeev@linux.ibm.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, kgraul@linux.ibm.com,
jaka@linux.ibm.com
Cc: borntraeger@linux.ibm.com, svens@linux.ibm.com,
alibuda@linux.alibaba.com, tonylu@linux.alibaba.com,
raspl@linux.ibm.com, schnelle@linux.ibm.com,
guangguan.wang@linux.alibaba.com, linux-s390@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v8 03/10] net/smc: unify the structs of accept or confirm message for v1 and v2
Date: Wed, 20 Dec 2023 11:27:45 +0100 [thread overview]
Message-ID: <f43f77f9-416b-4ef6-9def-f0dd1b7a3efb@linux.ibm.com> (raw)
In-Reply-To: <20231219142616.80697-4-guwen@linux.alibaba.com>
On 19.12.23 15:26, Wen Gu wrote:
> The structs of CLC accept and confirm messages for SMCv1 and SMCv2 are
> separately defined and often casted to each other in the code, which may
> increase the risk of errors caused by future divergence of them. So
> unify them into one struct for better maintainability.
>
> Suggested-by: Alexandra Winter <wintera@linux.ibm.com>
> Signed-off-by: Wen Gu <guwen@linux.alibaba.com>
> ---
> net/smc/af_smc.c | 52 +++++++++++++------------------------
> net/smc/smc_clc.c | 65 ++++++++++++++++++++---------------------------
> net/smc/smc_clc.h | 42 +++++++++++++-----------------
> 3 files changed, 62 insertions(+), 97 deletions(-)
Thanks a lot Wen Gu, I really love this.
Using an unnamed union is a great solution here. Now the code is so much more
readable and maintainable
Reviewed-by: Alexandra Winter <wintera@linux.ibm.com>
next prev parent reply other threads:[~2023-12-20 10:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 14:26 [PATCH net-next v8 00/10] net/smc: implement SMCv2.1 virtual ISM device support Wen Gu
2023-12-19 14:26 ` [PATCH net-next v8 01/10] net/smc: rename some 'fce' to 'fce_v2x' for clarity Wen Gu
2023-12-19 14:26 ` [PATCH net-next v8 02/10] net/smc: introduce sub-functions for smc_clc_send_confirm_accept() Wen Gu
2023-12-19 14:26 ` [PATCH net-next v8 03/10] net/smc: unify the structs of accept or confirm message for v1 and v2 Wen Gu
2023-12-20 10:27 ` Alexandra Winter [this message]
2023-12-20 11:37 ` Alexandra Winter
2023-12-20 12:16 ` Wen Gu
2023-12-19 14:26 ` [PATCH net-next v8 04/10] net/smc: support SMCv2.x supplemental features negotiation Wen Gu
2023-12-19 14:26 ` [PATCH net-next v8 05/10] net/smc: introduce virtual ISM device support feature Wen Gu
2023-12-19 14:26 ` [PATCH net-next v8 06/10] net/smc: define a reserved CHID range for virtual ISM devices Wen Gu
2023-12-19 14:26 ` [PATCH net-next v8 07/10] net/smc: compatible with 128-bits extended GID of virtual ISM device Wen Gu
2024-01-24 14:29 ` [REGRESSION] v6.8 SMC-D issues Alexandra Winter
2024-01-24 14:44 ` Alexandra Winter
2024-01-25 4:59 ` Wen Gu
2024-01-25 8:26 ` Alexandra Winter
2024-01-25 9:28 ` Wen Gu
2023-12-19 14:26 ` [PATCH net-next v8 08/10] net/smc: support extended GID in SMC-D lgr netlink attribute Wen Gu
2023-12-19 14:26 ` [PATCH net-next v8 09/10] net/smc: disable SEID on non-s390 archs where virtual ISM may be used Wen Gu
2023-12-19 14:26 ` [PATCH net-next v8 10/10] net/smc: manage system EID in SMC stack instead of ISM driver Wen Gu
2023-12-20 13:34 ` [PATCH net-next v8 00/10] net/smc: implement SMCv2.1 virtual ISM device support Wen Gu
2023-12-26 20:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f43f77f9-416b-4ef6-9def-f0dd1b7a3efb@linux.ibm.com \
--to=wintera@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=alibuda@linux.alibaba.com \
--cc=borntraeger@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gor@linux.ibm.com \
--cc=guangguan.wang@linux.alibaba.com \
--cc=guwen@linux.alibaba.com \
--cc=hca@linux.ibm.com \
--cc=jaka@linux.ibm.com \
--cc=kgraul@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=raspl@linux.ibm.com \
--cc=schnelle@linux.ibm.com \
--cc=svens@linux.ibm.com \
--cc=tonylu@linux.alibaba.com \
--cc=wenjia@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).