From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFF6FC19759 for ; Thu, 1 Aug 2019 19:51:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9205520679 for ; Thu, 1 Aug 2019 19:51:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="W5jF4sqs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388818AbfHATv3 (ORCPT ); Thu, 1 Aug 2019 15:51:29 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:38958 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388633AbfHATv3 (ORCPT ); Thu, 1 Aug 2019 15:51:29 -0400 Received: by mail-pg1-f193.google.com with SMTP id u17so34776368pgi.6 for ; Thu, 01 Aug 2019 12:51:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Vt28EcxxBo2EnWu4rBDgHlsTPZ+2ZNh4vId1YX1INoU=; b=W5jF4sqskJuwd7g/oDi1Uvwfk6b/AJQHZ8zFTtpYQtt6QO8XtzIEJDC7u854ksyn2X bJPuRo9xuPzsAdfgVPIcJU33fhdbfQuB4M/SG9gc0Rl0Cq9Tbud4dkMDiI5GZ6Kx4AUA KtGJLNG5fupQGO0wh0+MI618WtFCRoPb28e6beks4/lmjMjBKT2cFyhz7ISpts94kEfU UfUaTBTUUVLnWq11ItCoAlM8GgT8CFWTTG2TFR3fPYJWC9Rxu523IiWNxoYeDjQsik67 8JEPU2Ss+mcBTleI/tvnno8NL11k3IEt3VbnMdZ3Tm8jrceUYRJM+NN4Fi8VHS33g9fQ peIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Vt28EcxxBo2EnWu4rBDgHlsTPZ+2ZNh4vId1YX1INoU=; b=LNP4rEk+ASZhD/Fljjmxm/nORLq4G87AVJ/LBR0F/ia98MaLi9I8Oqolo8qP0kmoN9 bSC240+eTBtzPPX7Xn1GJxtDyYIuQn7Ci2IdGSZb2jXd4P88e758wau+Lrwl3h6Reu9u BlOAhVP9qjPbYfra5R0nISMMUDSE0VwFxfP+NcDvvMy6IPyUGbLoCSBPXdDaMGoY1AHy EjskadBih5GEon7F5dbqft1fdNGstJJA9KeXdZUHkQMyRIhVSb/PdBa04TBZv8z8wxSm xWgHjn0/3suqlxO1yORXOXsAjHwGXM1gsiu6GGyQIU2lT3HUSavHawSwsEAIZK0hpBDu bLVw== X-Gm-Message-State: APjAAAWavaHfBXW7VTFLwNYzGysm3Slc2JocOAMRRG+QPO5CadhjZAlH N+h4wu50QG2KrVqJMrbBPOw= X-Google-Smtp-Source: APXvYqwUa+1xMhBFHgI0Rgl6vDR4C/iEsC7uI8T+JHL/sXk0HYNG9yZIXLwJ/LfUjGtpkn63V2m/gg== X-Received: by 2002:a63:f456:: with SMTP id p22mr45391934pgk.45.1564689088659; Thu, 01 Aug 2019 12:51:28 -0700 (PDT) Received: from [172.27.227.186] ([216.129.126.118]) by smtp.googlemail.com with ESMTPSA id l4sm73969909pff.50.2019.08.01.12.51.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Aug 2019 12:51:27 -0700 (PDT) Subject: Re: [PATCH net] ipv4/route: do not check saddr dev if iif is LOOPBACK_IFINDEX To: Hangbin Liu , netdev@vger.kernel.org Cc: Stefano Brivio , Marcelo Ricardo Leitner , David Ahern , "David S . Miller" References: <20190801082900.27216-1-liuhangbin@gmail.com> From: David Ahern Message-ID: Date: Thu, 1 Aug 2019 13:51:25 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190801082900.27216-1-liuhangbin@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 8/1/19 2:29 AM, Hangbin Liu wrote: > Jianlin reported a bug that for IPv4, ip route get from src_addr would fail > if src_addr is not an address on local system. > > \# ip route get 1.1.1.1 from 2.2.2.2 > RTNETLINK answers: Invalid argument so this is a forwarding lookup in which case iif should be set. Based on the above 'route get' inet_rtm_getroute is doing a lookup as if it is locally generated traffic.