netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	dchickles@marvell.com,  sburla@marvell.com,
	fmanlunas@marvell.com, davem@davemloft.net,  edumazet@google.com,
	kuba@kernel.org, veerasenareddy.burru@cavium.com
Cc: felix.manlunas@cavium.com, netdev@vger.kernel.org,
	 linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net 2/2] liquidio: Simplify octeon_download_firmware()
Date: Tue, 24 Oct 2023 13:11:13 +0200	[thread overview]
Message-ID: <f44e4fd716729f1f35ef58895b1acde53adb9b35.camel@redhat.com> (raw)
In-Reply-To: <0278c7dfbc23f78a2d85060369132782f8466090.1698007858.git.christophe.jaillet@wanadoo.fr>

On Sun, 2023-10-22 at 22:59 +0200, Christophe JAILLET wrote:
> In order to remove the usage of strncat(), write directly at the rigth
> place in the 'h->bootcmd' array and check if the output is truncated.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> The goal is to potentially remove the strncat() function from the kernel.
> Their are only few users and most of them use it wrongly.
> 
> This patch is compile tested only.

Then just switch to strlcat, would be less invasive.

Thanks,

Paolo


  parent reply	other threads:[~2023-10-24 11:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-22 20:59 [PATCH net 0/2] liquidio: Fix an off by one in octeon_download_firmware() Christophe JAILLET
2023-10-22 20:59 ` [PATCH net 1/2] " Christophe JAILLET
2023-10-22 20:59 ` [PATCH net 2/2] liquidio: Simplify octeon_download_firmware() Christophe JAILLET
2023-10-24  0:29   ` Jacob Keller
2023-10-24 11:11   ` Paolo Abeni [this message]
2023-10-24 12:10     ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f44e4fd716729f1f35ef58895b1acde53adb9b35.camel@redhat.com \
    --to=pabeni@redhat.com \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=davem@davemloft.net \
    --cc=dchickles@marvell.com \
    --cc=edumazet@google.com \
    --cc=felix.manlunas@cavium.com \
    --cc=fmanlunas@marvell.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sburla@marvell.com \
    --cc=veerasenareddy.burru@cavium.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).