From: David Ahern <dsahern@gmail.com>
To: Xin Long <lucien.xin@gmail.com>, network dev <netdev@vger.kernel.org>
Cc: davem@davemloft.net
Subject: Re: [PATCH net] netlink: reset extack earlier in netlink_rcv_skb
Date: Thu, 18 Jan 2018 09:10:51 -0800 [thread overview]
Message-ID: <f4750213-c1d4-117c-5752-5de775135a4a@gmail.com> (raw)
In-Reply-To: <19a629d2b8f53141d60f3896a62152f372d071b9.1516258083.git.lucien.xin@gmail.com>
On 1/17/18 10:48 PM, Xin Long wrote:
> Move up the extack reset/initialization in netlink_rcv_skb, so that
> those 'goto ack' will not skip it. Otherwise, later on netlink_ack
> may use the uninitialized extack and cause kernel crash.
>
> Fixes: cbbdf8433a5f ("netlink: extack needs to be reset each time through loop")
> Reported-by: syzbot+03bee3680a37466775e7@syzkaller.appspotmail.com
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
> ---
> net/netlink/af_netlink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: David Ahern <dsahern@gmail.com>
next prev parent reply other threads:[~2018-01-18 17:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-18 6:48 [PATCH net] netlink: reset extack earlier in netlink_rcv_skb Xin Long
2018-01-18 17:10 ` David Ahern [this message]
2018-01-18 20:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4750213-c1d4-117c-5752-5de775135a4a@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).