From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH net] netlink: reset extack earlier in netlink_rcv_skb Date: Thu, 18 Jan 2018 09:10:51 -0800 Message-ID: References: <19a629d2b8f53141d60f3896a62152f372d071b9.1516258083.git.lucien.xin@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net To: Xin Long , network dev Return-path: Received: from mail-pg0-f48.google.com ([74.125.83.48]:32804 "EHLO mail-pg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755170AbeARRKx (ORCPT ); Thu, 18 Jan 2018 12:10:53 -0500 Received: by mail-pg0-f48.google.com with SMTP id u1so1351840pgr.0 for ; Thu, 18 Jan 2018 09:10:53 -0800 (PST) In-Reply-To: <19a629d2b8f53141d60f3896a62152f372d071b9.1516258083.git.lucien.xin@gmail.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 1/17/18 10:48 PM, Xin Long wrote: > Move up the extack reset/initialization in netlink_rcv_skb, so that > those 'goto ack' will not skip it. Otherwise, later on netlink_ack > may use the uninitialized extack and cause kernel crash. > > Fixes: cbbdf8433a5f ("netlink: extack needs to be reset each time through loop") > Reported-by: syzbot+03bee3680a37466775e7@syzkaller.appspotmail.com > Signed-off-by: Xin Long > --- > net/netlink/af_netlink.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Acked-by: David Ahern