From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Julius Volz" Subject: Re: [PATCH 00/26] IPVS: Add first IPv6 support to IPVS. Date: Wed, 11 Jun 2008 21:53:39 +0200 Message-ID: References: <1213204329-10973-1-git-send-email-juliusv@google.com> <48500A0D.5020304@trash.net> <48501C81.6010800@trash.net> <4850233E.7090501@trash.net> <48502826.9060502@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: lvs-devel@vger.kernel.org, netdev@vger.kernel.org, "Vince Busam" To: "Patrick McHardy" Return-path: Received: from smtp-out.google.com ([216.239.33.17]:40376 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754961AbYFKTxp (ORCPT ); Wed, 11 Jun 2008 15:53:45 -0400 Received: from zps37.corp.google.com (zps37.corp.google.com [172.25.146.37]) by smtp-out.google.com with ESMTP id m5BJreMV027381 for ; Wed, 11 Jun 2008 20:53:40 +0100 Received: from wf-out-1314.google.com (wfc25.prod.google.com [10.142.3.25]) by zps37.corp.google.com with ESMTP id m5BJrFWu005627 for ; Wed, 11 Jun 2008 12:53:39 -0700 Received: by wf-out-1314.google.com with SMTP id 25so3122785wfc.6 for ; Wed, 11 Jun 2008 12:53:39 -0700 (PDT) In-Reply-To: <48502826.9060502@trash.net> Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-ID: On Wed, Jun 11, 2008 at 9:31 PM, Patrick McHardy wrote: > Julius Volz wrote: >> It is clearly laid out to be able to be changed over time, hence the >> ipvsadm version check... > > The usual way is to add new members at the end. The history shows no > changes at all to these structs though. Not in git history at least. No version number change there either (maybe the LVS folks know more about the history). Adding members at the end sounds interesting! The current structs have the v4 address members in the middle of the struct, so you couldn't use a union of v4 and v6 anymore, but since it's only in the userspace interface, that shouldn't matter much. If this allows us to keep the interface backwards compatible in an easy way, that would be great. Julius -- Google Switzerland GmbH