From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Julius Volz" Subject: Re: [PATCH 00/26] IPVS: Add first IPv6 support to IPVS. Date: Tue, 17 Jun 2008 01:19:14 +0200 Message-ID: References: <485126BD.7030109@trash.net> <485144DF.3030102@trash.net> <20080613062621.GA10474@verge.net.au> <48528EED.7090307@trash.net> <485652EA.2020004@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "Simon Horman" , "Vince Busam" , "Ben Greear" , lvs-devel@vger.kernel.org, netdev@vger.kernel.org To: "Patrick McHardy" Return-path: Received: from smtp-out.google.com ([216.239.33.17]:62063 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754323AbYFPXTR (ORCPT ); Mon, 16 Jun 2008 19:19:17 -0400 Received: from zps75.corp.google.com (zps75.corp.google.com [172.25.146.75]) by smtp-out.google.com with ESMTP id m5GNJFx6011823 for ; Tue, 17 Jun 2008 00:19:15 +0100 Received: from wf-out-1314.google.com (wfc28.prod.google.com [10.142.3.28]) by zps75.corp.google.com with ESMTP id m5GNIZ28016667 for ; Mon, 16 Jun 2008 16:19:14 -0700 Received: by wf-out-1314.google.com with SMTP id 28so7155388wfc.11 for ; Mon, 16 Jun 2008 16:19:14 -0700 (PDT) In-Reply-To: <485652EA.2020004@trash.net> Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Jun 16, 2008 at 1:47 PM, Patrick McHardy wrote: >> Option c) looks reasonable to me and also seems easy to handle in >> general. Is this the way to go? Or do we want the interface to look >> completely different this time? > > b) or c) both look fine. A couple of other Netlink questions came up while reading some code: 1) There are many examples of the following two cases in the kernel: nla_nest_start(skb, SOME_ATTR_TYPE | NLA_F_NESTED); nla_nest_start(skb, SOME_ATTR_TYPE); Why don't all cases have NLA_F_NESTED? Then again, this bit is never ever read out again (at least not in the kernel), so I guess people are just using their implicit knowledge that a specific attribute type is always nested and never check the bit? Btw., couldn't we change nla_nest_start() to always add NLA_F_NESTED to the type? 2) To send an array of attributes of the same type, you just add them serially? I was just confused at first that nla_parse() will save only one attribute of each type (the last one) in the destination array, so when dealing with arrays, it doesn't help. So I just iterate over the array with nla_for_each_attr() and parse each element manually, right? Thanks for your time! Julius -- Google Switzerland GmbH