From: "Julius Volz" <juliusv@google.com>
To: "Thomas Graf" <tgraf@suug.ch>
Cc: netdev@vger.kernel.org, lvs-devel@vger.kernel.org,
horms@verge.net.au, kaber@trash.net, davem@davemloft.net,
vbusam@google.com
Subject: Re: [PATCHv2 2/2] IPVS: Add genetlink interface implementation
Date: Sat, 26 Jul 2008 00:39:10 +0200 [thread overview]
Message-ID: <f4845fc0807251539w6fe4347dref663f07794cf45c@mail.gmail.com> (raw)
In-Reply-To: <20080724235833.GD20815@postel.suug.ch>
On Fri, Jul 25, 2008 at 1:58 AM, Thomas Graf <tgraf@suug.ch> wrote:
> * Julius Volz <juliusv@google.com> 2008-07-21 15:02
>> +static int ip_vs_genl_parse_dest(struct ip_vs_dest_user *udest,
>> + struct nlattr *nla, int full_entry)
>> +{
>> + struct nlattr *attrs[IPVS_SVC_ATTR_MAX + 1];
>> + struct nlattr *nla_addr, *nla_port;
>> +
>> + /* Parse mandatory identifying destination fields first */
>> + if (nla == NULL ||
>> + nla_parse_nested(attrs, IPVS_DEST_ATTR_MAX, nla, ip_vs_dest_policy))
>
> Small typo here, attrs[] is defined with a length of IPVS_SVC_ATTR_MAX+1
> while IPVS_DEST_ATTR_MAX is passed to to nla_parse_nested.
Right, thanks for catching this! Will include this in the next
iteration after vacation...
Julius
--
Google Switzerland GmbH
next prev parent reply other threads:[~2008-07-25 22:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-21 13:02 [PATCHv2 0/2] IPVS: Add Generic Netlink configuration interface Julius Volz
2008-07-21 13:02 ` [PATCHv2 1/2] IPVS: Add genetlink interface definitions to ip_vs.h Julius Volz
2008-07-21 13:02 ` [PATCHv2 2/2] IPVS: Add genetlink interface implementation Julius Volz
2008-07-24 23:58 ` Thomas Graf
2008-07-25 22:39 ` Julius Volz [this message]
2008-07-22 0:34 ` [PATCHv2 0/2] IPVS: Add Generic Netlink configuration interface Simon Horman
2008-07-22 16:43 ` Julius Volz
2008-07-22 22:59 ` Vince Busam
2008-07-23 21:39 ` Vince Busam
2008-07-25 5:58 ` Simon Horman
2008-07-25 22:36 ` Julius Volz
2008-07-25 23:29 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4845fc0807251539w6fe4347dref663f07794cf45c@mail.gmail.com \
--to=juliusv@google.com \
--cc=davem@davemloft.net \
--cc=horms@verge.net.au \
--cc=kaber@trash.net \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
--cc=vbusam@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).