From: "huangguangbin (A)" <huangguangbin2@huawei.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: <davem@davemloft.net>, <kuba@kernel.org>, <mkubecek@suse.cz>,
<amitc@mellanox.com>, <idosch@idosch.org>, <danieller@nvidia.com>,
<jesse.brandeburg@intel.com>, <anthony.l.nguyen@intel.com>,
<jdike@addtoit.com>, <richard@nod.at>,
<anton.ivanov@cambridgegreys.com>, <netanel@amazon.com>,
<akiyano@amazon.com>, <gtzalik@amazon.com>, <saeedb@amazon.com>,
<chris.snook@gmail.com>, <ulli.kroll@googlemail.com>,
<linus.walleij@linaro.org>, <jeroendb@google.com>,
<csully@google.com>, <awogbemila@google.com>, <jdmason@kudzu.us>,
<rain.1986.08.12@gmail.com>, <zyjzyj2000@gmail.com>,
<kys@microsoft.com>, <haiyangz@microsoft.com>, <mst@redhat.com>,
<jasowang@redhat.com>, <doshir@vmware.com>,
<pv-drivers@vmware.com>, <jwi@linux.ibm.com>,
<kgraul@linux.ibm.com>, <hca@linux.ibm.com>, <gor@linux.ibm.com>,
<johannes@sipsolutions.net>, <netdev@vger.kernel.org>,
<lipeng321@huawei.com>, <chenhao288@hisilicon.com>,
<linux-s390@vger.kernel.org>
Subject: Re: [PATCH V5 net-next 0/6] ethtool: add support to set/get tx copybreak buf size and rx buf len
Date: Mon, 1 Nov 2021 11:42:18 +0800 [thread overview]
Message-ID: <f4937fea-4693-e534-38db-e8c64158ce55@huawei.com> (raw)
In-Reply-To: <YX2H3yN2tJXKt+ai@lunn.ch>
On 2021/10/31 1:58, Andrew Lunn wrote:
>> Rx buf len is buffer length of each rx BD. Use ethtool -g command to get
>> it, and ethtool -G command to set it, examples are as follow:
>>
>> 1. set rx buf len to 4096
>> $ ethtool -G eth1 rx-buf-len 4096
>>
>> 2. get rx buf len
>> $ ethtool -g eth1
>> ...
>> RX Buf Len: 4096
>
> How does this interact with MTU? If i have an MTU of 1500, and i set
> the rx-buf-len to 1000, can i expect all frames to the discarded?
> Should the core return -EINVAL? Or do you think some hardware will
> simply allocate two buffers and scatter/gather over them? Which
> implies that drivers which cannot SG must check if the rx-buf-len is
> less than the MTU and return -EINVAL?
>
> Andrew
> .
>
Yes, hns3 driver supports scatter/gather for this situation, it's necessary
for driver which cannot support SG to check if rx buf len is less than mtu.
prev parent reply other threads:[~2021-11-01 3:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-30 13:09 [PATCH V5 net-next 0/6] ethtool: add support to set/get tx copybreak buf size and rx buf len Guangbin Huang
2021-10-30 13:09 ` [PATCH V5 net-next 1/6] ethtool: add support to set/get tx copybreak buf size via ethtool Guangbin Huang
2021-10-30 13:09 ` [PATCH V5 net-next 2/6] net: hns3: add support to set/get tx copybreak buf size via ethtool for hns3 driver Guangbin Huang
2021-10-30 13:09 ` [PATCH V5 net-next 3/6] ethtool: add support to set/get rx buf len via ethtool Guangbin Huang
2021-10-30 13:09 ` [PATCH V5 net-next 4/6] ethtool: extend ringparam setting/getting API with rx_buf_len Guangbin Huang
2021-10-30 13:10 ` [PATCH V5 net-next 5/6] net: hns3: add support to set/get rx buf len via ethtool for hns3 driver Guangbin Huang
2021-10-30 18:04 ` Andrew Lunn
2021-10-30 13:10 ` [PATCH V5 net-next 6/6] net: hns3: remove the way to set tx spare buf via module parameter Guangbin Huang
2021-10-30 18:05 ` Andrew Lunn
2021-11-01 3:43 ` huangguangbin (A)
2021-10-30 17:58 ` [PATCH V5 net-next 0/6] ethtool: add support to set/get tx copybreak buf size and rx buf len Andrew Lunn
2021-11-01 3:42 ` huangguangbin (A) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4937fea-4693-e534-38db-e8c64158ce55@huawei.com \
--to=huangguangbin2@huawei.com \
--cc=akiyano@amazon.com \
--cc=amitc@mellanox.com \
--cc=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=awogbemila@google.com \
--cc=chenhao288@hisilicon.com \
--cc=chris.snook@gmail.com \
--cc=csully@google.com \
--cc=danieller@nvidia.com \
--cc=davem@davemloft.net \
--cc=doshir@vmware.com \
--cc=gor@linux.ibm.com \
--cc=gtzalik@amazon.com \
--cc=haiyangz@microsoft.com \
--cc=hca@linux.ibm.com \
--cc=idosch@idosch.org \
--cc=jasowang@redhat.com \
--cc=jdike@addtoit.com \
--cc=jdmason@kudzu.us \
--cc=jeroendb@google.com \
--cc=jesse.brandeburg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=jwi@linux.ibm.com \
--cc=kgraul@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=linus.walleij@linaro.org \
--cc=linux-s390@vger.kernel.org \
--cc=lipeng321@huawei.com \
--cc=mkubecek@suse.cz \
--cc=mst@redhat.com \
--cc=netanel@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=rain.1986.08.12@gmail.com \
--cc=richard@nod.at \
--cc=saeedb@amazon.com \
--cc=ulli.kroll@googlemail.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).