From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DF31C169C4 for ; Wed, 6 Feb 2019 11:45:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CE0D4218A3 for ; Wed, 6 Feb 2019 11:45:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=synopsys.com header.i=@synopsys.com header.b="ekneBE1A" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728076AbfBFLpw (ORCPT ); Wed, 6 Feb 2019 06:45:52 -0500 Received: from us01smtprelay-2.synopsys.com ([198.182.60.111]:35808 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727080AbfBFLpv (ORCPT ); Wed, 6 Feb 2019 06:45:51 -0500 Received: from mailhost.synopsys.com (dc8-mailhost2.synopsys.com [10.13.135.210]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtprelay.synopsys.com (Postfix) with ESMTPS id 2288310C1E1F; Wed, 6 Feb 2019 03:45:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1549453551; bh=WBUjJpEW7cfJBpTbz1512QqDcoX3C+Jjzu6LOEiJzqg=; h=Subject:To:CC:References:From:Date:In-Reply-To:From; b=ekneBE1AcIt3VOc4ouTh2y4bdAd9YTEL0KPPcZK9Gc0oWEAzBEwXjtrWAbwvBuUEF BfAECdWHCrb4qzRGctTNSSt0Fw3VKzT/0vl2bsCuN+/3KHtnstlexGHhhHmVoDXV2K CXgYi+z7h3nWPBcwVBEyNHYMwTQlhcv0Ta/DfmM9XtFDLInGrWmwCCAkCB6PtyWyd0 NyNCV8MYdCJb6oyOEhW4znfLODPlgclVaUAfsJVcPoV/shYm0k3psVNgeMHqZTgaxj f+l0OAcLH8ifRqoONQpApGSE6rtJMKUPSHVYWfrIM77EtRoNhN/OcyBwYczA7VSsFT 2lfI665Ap7V5w== Received: from us01wehtc1.internal.synopsys.com (us01wehtc1-vip.internal.synopsys.com [10.12.239.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mailhost.synopsys.com (Postfix) with ESMTPS id 43FA3A0062; Wed, 6 Feb 2019 11:45:50 +0000 (UTC) Received: from DE02WEHTCB.internal.synopsys.com (10.225.19.94) by us01wehtc1.internal.synopsys.com (10.12.239.231) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 6 Feb 2019 03:45:48 -0800 Received: from DE02WEHTCA.internal.synopsys.com (10.225.19.92) by DE02WEHTCB.internal.synopsys.com (10.225.19.94) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 6 Feb 2019 12:45:46 +0100 Received: from [10.107.19.176] (10.107.19.176) by DE02WEHTCA.internal.synopsys.com (10.225.19.80) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 6 Feb 2019 12:45:45 +0100 Subject: Re: [net-next, PATCH] net: stmmac: fix ptp timestamping on Rx on gmac4 To: Ilias Apalodimas , CC: , , , , References: <1549368920-1989-1-git-send-email-ilias.apalodimas@linaro.org> From: Jose Abreu Message-ID: Date: Wed, 6 Feb 2019 11:45:44 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <1549368920-1989-1-git-send-email-ilias.apalodimas@linaro.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.107.19.176] Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/5/2019 12:15 PM, Ilias Apalodimas wrote: > The current driver only enables Pdelay_Req and Pdelay_Resp when > HWTSTAMP_FILTER_PTP_V2_EVENT, HWTSTAMP_FILTER_PTP_V1_L4_EVENT or > HWTSTAMP_FILTER_PTP_V2_L4_EVENT is requested. This results in ptp sync on > slave mode to report 'received SYNC without timestamp' when using ptp4l. > > Although the hardware can support Sync, Pdelay_Req and Pdelay_resp by > setting bit14 annd bits 17/16 to 01 this leaves Delay_Req timestamps out. > > Fix this by enabling all event and general messages timestamps. > This includes SYNC, Follow_Up, Delay_Req, Delay_Resp, Pdelay_Req, > Pdelay_Resp and Pdelay_Resp_Follow_Up messages. > > Signed-off-by: Ilias Apalodimas Acked-by: Jose Abreu and, on XGMAC2: Tested-by: Jose Abreu Thanks, Jose Miguel Abreu