From: Alexander Lobakin <aleksander.lobakin@intel.com>
To: Justin Lai <justinlai0215@realtek.com>
Cc: <kuba@kernel.org>, <davem@davemloft.net>, <edumazet@google.com>,
<pabeni@redhat.com>, <andrew+netdev@lunn.ch>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<horms@kernel.org>, <pkshih@realtek.com>,
<larry.chiu@realtek.com>
Subject: Re: [PATCH] rtase: Avoid sleeping in get_stats64()
Date: Mon, 1 Jun 2026 15:14:50 +0200 [thread overview]
Message-ID: <f4b96c08-c6f7-422f-aceb-aa48fa2bfef6@intel.com> (raw)
In-Reply-To: <20260601062447.64027-1-justinlai0215@realtek.com>
From: Justin Lai <justinlai0215@realtek.com>
Date: Mon, 1 Jun 2026 14:24:47 +0800
> The .ndo_get_stats64 callback must not sleep because it can be
> called when reading /proc/net/dev.
>
> rtase_get_stats64() calls rtase_dump_tally_counter(), which polls
> the tally counter dump bit with read_poll_timeout(). This may
> sleep while waiting for the hardware counter dump to complete.
>
> Use read_poll_timeout_atomic() instead to avoid sleeping in the
> get_stats64() path.
>
> Signed-off-by: Justin Lai <justinlai0215@realtek.com>
Looks legit.
One question: for how long can this poll for in real life scenarios? Up
to ~1 ms is okay-ish for atomic, but if longer, then you'd better to
split it into shorter polls and reschedule() time to time.
Thanks,
Olek
next prev parent reply other threads:[~2026-06-01 13:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-01 6:24 [PATCH] rtase: Avoid sleeping in get_stats64() Justin Lai
2026-06-01 13:14 ` Alexander Lobakin [this message]
2026-06-01 21:42 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4b96c08-c6f7-422f-aceb-aa48fa2bfef6@intel.com \
--to=aleksander.lobakin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=justinlai0215@realtek.com \
--cc=kuba@kernel.org \
--cc=larry.chiu@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox