From: David Ahern <dsahern@kernel.org>
To: Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next 1/4] ipv6: make inet6_fill_ifaddr() lockless
Date: Wed, 6 Mar 2024 16:38:29 -0700 [thread overview]
Message-ID: <f4bcf5fd-b1b0-47a8-9eb3-5aae2c5171b7@kernel.org> (raw)
In-Reply-To: <20240306155144.870421-2-edumazet@google.com>
On 3/6/24 8:51 AM, Eric Dumazet wrote:
> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
> index 2f84e6ecf19f48602cadb47bc378c9b5a1cdbf65..480a1f9492b590bb13008cede5ea7dc9c422af67 100644
> --- a/net/ipv6/addrconf.c
> +++ b/net/ipv6/addrconf.c
> @@ -2730,7 +2730,7 @@ int addrconf_prefix_rcv_add_addr(struct net *net, struct net_device *dev,
> if (update_lft) {
> ifp->valid_lft = valid_lft;
> ifp->prefered_lft = prefered_lft;
> - ifp->tstamp = now;
> + WRITE_ONCE(ifp->tstamp, now);
There are a lot of instances of ifp->tstamp not annotated with READ_ONCE
or WRITE_ONCE. Most of them before this function seem to be updated or
read under rtnl. What's the general mode of operation for this patch?
e.g., there are tstamp references just above this one in this function
not modified. Commit message does not describe why some are updated and
others not.
next prev parent reply other threads:[~2024-03-06 23:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 15:51 [PATCH net-next 0/4] ipv6: lockless inet6_dump_addr() Eric Dumazet
2024-03-06 15:51 ` [PATCH net-next 1/4] ipv6: make inet6_fill_ifaddr() lockless Eric Dumazet
2024-03-06 23:38 ` David Ahern [this message]
2024-03-07 6:24 ` Eric Dumazet
2024-03-08 15:26 ` David Ahern
2024-03-08 19:31 ` Jakub Kicinski
2024-03-06 15:51 ` [PATCH net-next 2/4] ipv6: make in6_dump_addrs() lockless Eric Dumazet
2024-03-06 15:51 ` [PATCH net-next 3/4] ipv6: use xa_array iterator to implement inet6_dump_addr() Eric Dumazet
2024-03-06 15:51 ` [PATCH net-next 4/4] ipv6: remove RTNL protection from inet6_dump_addr() Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4bcf5fd-b1b0-47a8-9eb3-5aae2c5171b7@kernel.org \
--to=dsahern@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).