From: Andrew Lunn <andrew@lunn.ch>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
davem@davemloft.net, Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Russell King <linux@armlinux.org.uk>,
Heiner Kallweit <hkallweit1@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
thomas.petazzoni@bootlin.com, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH net-next] net: phy: at803x: Use a helper to check for phy reset existence
Date: Wed, 15 Jul 2026 15:16:52 +0200 [thread overview]
Message-ID: <f4c935be-7b4d-4852-bca4-2d04d342af4d@lunn.ch> (raw)
In-Reply-To: <20260715101355.88536-1-maxime.chevallier@bootlin.com>
On Wed, Jul 15, 2026 at 12:13:54PM +0200, Maxime Chevallier wrote:
> The at803x family of devices are subjected to an errata that requires
> hard-reseting the PHY upon link change.
>
> That can only work if there's a physical reset line wired to the PHY,
> which the driver checks by looking if there's a reset GPIO configured
> for the MDIO device.
>
> The reset may however be controlled through a reset controller, which
> isn't accounted for in the errata handling.
>
> Besides that, PHY drivers aren't expected to directly access the
> mdiodev's resources directly, let's therefore wrap this with a phylib
> helper, that uses a similar mdio helper to check for reset existence.
>
> This was found in preparation for bus-level resource management for
> better mdio scan support.
>
> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2026-07-15 13:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-15 10:13 [PATCH net-next] net: phy: at803x: Use a helper to check for phy reset existence Maxime Chevallier
2026-07-15 13:16 ` Andrew Lunn [this message]
2026-07-15 19:17 ` Nicolai Buchwitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4c935be-7b4d-4852-bca4-2d04d342af4d@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox