From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F309221540 for ; Mon, 17 Mar 2025 09:23:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742203443; cv=none; b=mpN4+oe/mr/Ewg7ec6dscpO+nx8JZffPOJkhB4XHjq0tuW0QcuwRQBkJFSkr10yswnjEabTtlxzJGnq/ucpIRbz3CGfRMAAGmpOQ/pYxLhxBkhZs9DVHfKRiNEzZM3gQQsmVt5j6i8JI45Wobzdw6X4SLz7VtDqx2kCuEzvWlEM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742203443; c=relaxed/simple; bh=EVq1AhucL0DSGBtjqCNwBk9bQ+p1L1JBDrICPMXBitY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RxwbSp90vBIP4+LWho0o6ZVaHHWz+wFFc4qaePmy5AXaWM1WX/hInrDJ9ugSdhNWELsCR5xFEQjZk8nxAdjIc5sJvVB/W4mAcmuzj/AQxFALLV0vcvJngvrqf2xrt92LFt57u+MncHE1OCR720ILG7agKQf0au0ktMVvVEGCLUY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=openvpn.net; spf=pass smtp.mailfrom=openvpn.com; dkim=pass (2048-bit key) header.d=openvpn.net header.i=@openvpn.net header.b=OwbuXlLD; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=openvpn.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=openvpn.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=openvpn.net header.i=@openvpn.net header.b="OwbuXlLD" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-abbd96bef64so752465866b.3 for ; Mon, 17 Mar 2025 02:23:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1742203438; x=1742808238; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=WiCx14/fbOpW7YT89TZj+10cBQJw3y3n1vD7ajH4XHY=; b=OwbuXlLD7e41dVYezsTOgT1fBYR5ARQqcbB8eDUiKqwGRD3d24IvSsQWF8STTXp6zF DCgNePEtVT23aeAAcuHRHqAujAeQoPGydACZcpMG4bJl1/gee1sxSMFrQkbI63hH2Aim yLzh7qnmSRWzo+lLlaJnhn0wxBh85MFUoH42cSRcxbxVJ6lYO0D8I2EZ6jVEAIYWvWpm wI1cgIgQDpQu4fFMgplecijo8AKwNcdGXGcr7+QiuuIHa+8WzmTh7ZIif7v3XMB2g69P kjUPVOJehfF8/s8UjUywhFiyao1k2V9ajvXs9T/CDhm5FDmkAB2gam7hEllgk5booIO8 fzig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742203438; x=1742808238; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WiCx14/fbOpW7YT89TZj+10cBQJw3y3n1vD7ajH4XHY=; b=UJhLBHKv9BcnhEoWTttGSxWviuwh5vvNqmOzc+Q/I9hQaPCkCq1ASQo4kkTTEUKJwC +dL9ocmkayS5LIEaR2WAFqtclvyyTIQYpsqocRdKH+Nmt69HS5BTU8gBPdazotKxKV2l C8ahQVrzwL54EOzoyGrtVU4sZZCObJP+qbypk5WsTQzWAC+UybopwfRAQa2ZlrQ/4jIr 4WalXlH3keVvNG5yxn08dj/HdoGZXNvCUZTRWY7qgpPG9Wckl+OLsk5Z0DnPXXdIbZ+U wHpD0xlXAN/r1N/c8Ex/lt5ozrTraDpp3g2ZNGUHBR/agAfYW9HPKOksOJUxGgQ/3gMh KcQg== X-Forwarded-Encrypted: i=1; AJvYcCUVOQakjy/9E0ia26OHzbUHfm8WvuVlbsQ9O5YlFDKkBJrRWahtXEf00m4oxVkwnKu8t3FYwyY=@vger.kernel.org X-Gm-Message-State: AOJu0YyMk2Le+kqgXmRr9bTc9htMTHpRoyEcZa8H4DSvhiwP6F9y0M+I rH+f4Tt7eUh5dwe4HKwfW1sfbtWMbGAqATzL87ZGeaFDgeNNFlPxwFQgxj9rwmAv4oPPmw9Dm2q uIV6CO/13nMv+8l7EEUJ6LhVWtVa+JCazCRK5/7I/Sq/o7W4= X-Gm-Gg: ASbGnctnbagxSDUVO7seV6G7VJjjBABwrBHaftKVItB76ULLP3Qs8C2k/9BIh3RySxk zLAdN8rPMohzgz2cGgGckXSG6PdgsvyWQXRLPRI21zP72zZltulHxXiMV9m8H36qKeB4TW/80WP ieEO+Es4/aiG4Y79dT6/JZ+3Mzk0yq1tt5RcCE2aaogp7wajHsZuybloUGTBilKbiINkftG9sWM UPE9n2dGhdyIjKyBB7YOE2YJ4kI0nEzTNtAZsonxsaf1WULEKPQJsfaPHZ5re8Ct1JhJkUx4tst ki3LFLz/Ieq9Wh+TEv9pZaButBPZRCT07AHbMFnJhC07bCe3y6ZmcqMJ8uq2WQbXZICZHDGY2we dY4kvAFg= X-Google-Smtp-Source: AGHT+IErvInbMhT7sGTTX0jJhg0JlOT6PImo4k31XW/PWatNvrne26uyWDQoJh/nc1ZBX2hWlTdBaQ== X-Received: by 2002:a17:906:4795:b0:ac3:17bb:34f8 with SMTP id a640c23a62f3a-ac330108af4mr1375864166b.4.1742203437660; Mon, 17 Mar 2025 02:23:57 -0700 (PDT) Received: from ?IPV6:2001:67c:2fbc:1:23e9:a6ad:805e:ca75? ([2001:67c:2fbc:1:23e9:a6ad:805e:ca75]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac314a489e0sm626534366b.151.2025.03.17.02.23.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Mar 2025 02:23:57 -0700 (PDT) Message-ID: Date: Mon, 17 Mar 2025 10:23:55 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v23 03/23] ovpn: add basic interface creation/destruction/management routines To: Qingfang Deng Cc: andrew+netdev@lunn.ch, donald.hunter@gmail.com, edumazet@google.com, horms@kernel.org, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, ryazanov.s.a@gmail.com, sd@queasysnail.net, shaw.leon@gmail.com, shuah@kernel.org References: <20250312-b4-ovpn-v23-3-76066bc0a30c@openvpn.net> <20250317060947.2368390-1-dqfext@gmail.com> Content-Language: en-US From: Antonio Quartulli Autocrypt: addr=antonio@openvpn.net; keydata= xsFNBFN3k+ABEADEvXdJZVUfqxGOKByfkExNpKzFzAwHYjhOb3MTlzSLlVKLRIHxe/Etj13I X6tcViNYiIiJxmeHAH7FUj/yAISW56lynAEt7OdkGpZf3HGXRQz1Xi0PWuUINa4QW+ipaKmv voR4b1wZQ9cZ787KLmu10VF1duHW/IewDx9GUQIzChqQVI3lSHRCo90Z/NQ75ZL/rbR3UHB+ EWLIh8Lz1cdE47VaVyX6f0yr3Itx0ZuyIWPrctlHwV5bUdA4JnyY3QvJh4yJPYh9I69HZWsj qplU2WxEfM6+OlaM9iKOUhVxjpkFXheD57EGdVkuG0YhizVF4p9MKGB42D70pfS3EiYdTaKf WzbiFUunOHLJ4hyAi75d4ugxU02DsUjw/0t0kfHtj2V0x1169Hp/NTW1jkqgPWtIsjn+dkde dG9mXk5QrvbpihgpcmNbtloSdkRZ02lsxkUzpG8U64X8WK6LuRz7BZ7p5t/WzaR/hCdOiQCG RNup2UTNDrZpWxpwadXMnJsyJcVX4BAKaWGsm5IQyXXBUdguHVa7To/JIBlhjlKackKWoBnI Ojl8VQhVLcD551iJ61w4aQH6bHxdTjz65MT2OrW/mFZbtIwWSeif6axrYpVCyERIDEKrX5AV rOmGEaUGsCd16FueoaM2Hf96BH3SI3/q2w+g058RedLOZVZtyQARAQABzSdBbnRvbmlvIFF1 YXJ0dWxsaSA8YW50b25pb0BvcGVudnBuLm5ldD7Cwa0EEwEIAFcCGwMFCwkIBwMFFQoJCAsF FgIDAQACHgECF4AFCRWQ2TIWIQTKvaEoIBfCZyGYhcdI8My2j1nRTAUCYRUquBgYaGtwczov L2tleXMub3BlbnBncC5vcmcACgkQSPDMto9Z0UzmcxAAjzLeD47We0R4A/14oDKlZxXO0mKL fCzaWFsdhQCDhZkgxoHkYRektK2cEOh4Vd+CnfDcPs/iZ1i2+Zl+va79s4fcUhRReuwi7VCg 7nHiYSNC7qZo84Wzjz3RoGYyJ6MKLRn3zqAxUtFECoS074/JX1sLG0Z3hi19MBmJ/teM84GY IbSvRwZu+VkJgIvZonFZjbwF7XyoSIiEJWQC+AKvwtEBNoVOMuH0tZsgqcgMqGs6lLn66RK4 tMV1aNeX6R+dGSiu11i+9pm7sw8tAmsfu3kQpyk4SB3AJ0jtXrQRESFa1+iemJtt+RaSE5LK 5sGLAO+oN+DlE0mRNDQowS6q/GBhPCjjbTMcMfRoWPCpHZZfKpv5iefXnZ/xVj7ugYdV2T7z r6VL2BRPNvvkgbLZgIlkWyfxRnGh683h4vTqRqTb1wka5pmyBNAv7vCgqrwfvaV1m7J9O4B5 PuRjYRelmCygQBTXFeJAVJvuh2efFknMh41R01PP2ulXAQuVYEztq3t3Ycw6+HeqjbeqTF8C DboqYeIM18HgkOqRrn3VuwnKFNdzyBmgYh/zZx/dJ3yWQi/kfhR6TawAwz6GdbQGiu5fsx5t u14WBxmzNf9tXK7hnXcI24Z1z6e5jG6U2Swtmi8sGSh6fqV4dBKmhobEoS7Xl496JN2NKuaX jeWsF2rOwE0EZmhJFwEIAOAWiIj1EYkbikxXSSP3AazkI+Y/ICzdFDmiXXrYnf/mYEzORB0K vqNRQOdLyjbLKPQwSjYEt1uqwKaD1LRLbA7FpktAShDK4yIljkxhvDI8semfQ5WE/1Jj/I/Q U+4VXhkd6UvvpyQt/LiWvyAfvExPEvhiMnsg2zkQbBQ/M4Ns7ck0zQ4BTAVzW/GqoT2z03mg p1FhxkfzHMKPQ6ImEpuY5cZTQwrBUgWif6HzCtQJL7Ipa2fFnDaIHQeiJG0RXl/g9x3YlwWG sxOFrpWWsh6GI0Mo2W2nkinEIts48+wNDBCMcMlOaMYpyAI7fT5ziDuG2CBA060ZT7qqdl6b aXUAEQEAAcLBfAQYAQgAJhYhBMq9oSggF8JnIZiFx0jwzLaPWdFMBQJmaEkXAhsMBQkB4TOA AAoJEEjwzLaPWdFMbRUP/0t5FrjF8KY6uCU4Tx029NYKDN9zJr0CVwSGsNfC8WWonKs66QE1 pd6xBVoBzu5InFRWa2ed6d6vBw2BaJHC0aMg3iwwBbEgPn4Jx89QfczFMJvFm+MNc2DLDrqN zaQSqBzQ5SvUjxh8lQ+iqAhi0MPv4e2YbXD0ROyO+ITRgQVZBVXoPm4IJGYWgmVmxP34oUQh BM7ipfCVbcOFU5OPhd9/jn1BCHzir+/i0fY2Z/aexMYHwXUMha/itvsBHGcIEYKk7PL9FEfs wlbq+vWoCtUTUc0AjDgB76AcUVxxJtxxpyvES9aFxWD7Qc+dnGJnfxVJI0zbN2b37fX138Bf 27NuKpokv0sBnNEtsD7TY4gBz4QhvRNSBli0E5bGUbkM31rh4Iz21Qk0cCwR9D/vwQVsgPvG ioRqhvFWtLsEt/xKolOmUWA/jP0p8wnQ+3jY6a/DJ+o5LnVFzFqbK3fSojKbfr3bY33iZTSj DX9A4BcohRyqhnpNYyHL36gaOnNnOc+uXFCdoQkI531hXjzIsVs2OlfRufuDrWwAv+em2uOT BnRX9nFx9kPSO42TkFK55Dr5EDeBO3v33recscuB8VVN5xvh0GV57Qre+9sJrEq7Es9W609a +M0yRJWJEjFnMa/jsGZ+QyLD5QTL6SGuZ9gKI3W1SfFZOzV7hHsxPTZ6 Organization: OpenVPN Inc. In-Reply-To: <20250317060947.2368390-1-dqfext@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Qingfang and thanks for chiming in, On 17/03/2025 07:09, Qingfang Deng wrote: > Hi Antonio, > > On Wed, 12 Mar 2025 21:54:32 +0100, Antonio Quartulli Wrote: >> diff --git a/drivers/net/ovpn/main.c b/drivers/net/ovpn/main.c >> index 28133e7e15e74b8a4a937ed03f70d9f83d7a14c8..e71183e6f42cd801861caaec9eb0f6828b64cda9 100644 >> --- a/drivers/net/ovpn/main.c >> +++ b/drivers/net/ovpn/main.c >> @@ -10,14 +10,42 @@ >> #include >> #include >> #include >> +#include >> +#include >> #include >> -#include >> +#include >> >> #include "ovpnpriv.h" >> #include "main.h" >> #include "netlink.h" >> +#include "io.h" >> +#include "proto.h" >> + >> +static int ovpn_net_open(struct net_device *dev) >> +{ >> + netif_tx_start_all_queues(dev); > > This is not required as the virtual interface does not have a queue > (marked as IFF_NO_QUEUE). ACK > >> + return 0; >> +} >> + >> +static int ovpn_net_stop(struct net_device *dev) >> +{ >> + netif_tx_stop_all_queues(dev); > > Same as above. ACK > >> + return 0; >> +} >> >> static const struct net_device_ops ovpn_netdev_ops = { >> + .ndo_open = ovpn_net_open, >> + .ndo_stop = ovpn_net_stop, >> + .ndo_start_xmit = ovpn_net_xmit, >> +}; >> + >> +static const struct device_type ovpn_type = { >> + .name = OVPN_FAMILY_NAME, >> +}; >> + >> +static const struct nla_policy ovpn_policy[IFLA_OVPN_MAX + 1] = { >> + [IFLA_OVPN_MODE] = NLA_POLICY_RANGE(NLA_U8, OVPN_MODE_P2P, >> + OVPN_MODE_MP), >> }; >> >> /** >> @@ -31,44 +59,120 @@ bool ovpn_dev_is_valid(const struct net_device *dev) >> return dev->netdev_ops == &ovpn_netdev_ops; >> } >> >> +static void ovpn_setup(struct net_device *dev) >> +{ >> + netdev_features_t feat = NETIF_F_SG | NETIF_F_HW_CSUM | NETIF_F_RXCSUM | > > Do not advertise NETIF_F_HW_CSUM or NETIF_F_RXCSUM, as TX/RX checksum is > not handled in hardware. The idea behind these flags was that the OpenVPN protocol will take care of authenticating packets, thus substituting what the CSUM would do here. For this I wanted to avoid the stack to spend time computing the CSUM in software. I believe wireguard sets those flags for the same reason. Does it make sense to you? > >> + NETIF_F_GSO | NETIF_F_GSO_SOFTWARE | >> + NETIF_F_HIGHDMA; Regards, -- Antonio Quartulli OpenVPN Inc.