From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felix Fietkau Subject: Re: [PATCH] net: igmp: fix source address check for IGMPv3 reports Date: Tue, 23 Jan 2018 10:48:59 +0100 Message-ID: References: <20180119105046.44870-1-nbd@nbd.name> <20180122.161758.859663134125125839.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, cernekee@chromium.org, s.gottschall@dd-wrt.com To: David Miller Return-path: Received: from nbd.name ([46.4.11.11]:34710 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751204AbeAWJtF (ORCPT ); Tue, 23 Jan 2018 04:49:05 -0500 In-Reply-To: <20180122.161758.859663134125125839.davem@davemloft.net> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 2018-01-22 22:17, David Miller wrote: > From: Felix Fietkau > Date: Fri, 19 Jan 2018 11:50:46 +0100 > >> Commit "net: igmp: Use correct source address on IGMPv3 reports" >> introduced a check to validate the source address of locally generated >> IGMPv3 packets. >> Instead of checking the local interface address directly, it uses >> inet_ifa_match(fl4->saddr, ifa), which checks if the address is on the >> local subnet (or equal to the point-to-point address if used). >> >> This breaks for point-to-point interfaces, so check against >> ifa->ifa_local directly. >> >> Cc: Kevin Cernekee >> Fixes: a46182b00290 ("net: igmp: Use correct source address on IGMPv3 reports") >> Reported-by: Sebastian Gottschall >> Signed-off-by: Felix Fietkau > > Applied, thanks. Thanks. Please queue it up for stable as well, since the commit fixed by this patch has already made it to stable kernels. - Felix